Fix: the vulnerability in ZoomedScene.__init__(..) where zoomed_camera_image_mobject_config cannot be configured#4442
Open
MuRongxin wants to merge 3 commits intoManimCommunity:mainfrom
Conversation
…a_image_mobject_config cannot be configured
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In ZoomedScene, "zoomed_camera_image_mobject_config" cannot be configuredcausing :TypeError.
Motivation and Explanation:
In scenarios where picture-in-picture is used to zoom in on a part, it is not possible to modify the border color and thickness of the zoomed image through the configuration of
"zoomed_camera_image_mobject_config".The main reason for the problem lies in: passing improper parameters when using
ImageMobjectFromCamerainzoomed_scene.py; the"ImageMobjectFromCamera"class does not handleadd_display_frameappropriately.Test Example
Reviewer Checklist