offscreenBuffer initialize in main thread#84
Open
bldrvnlw wants to merge 2 commits into
Open
Conversation
ThomasKroes
reviewed
Nov 22, 2023
Contributor
There was a problem hiding this comment.
On Windows 11 MVS crashes:
tSNE initialized.
Sparse matrix allocated.
Computing high dimensional probability distributions.. Num dims: 13 Num data points: 167281
Probability distributions calculated.
A-tSNE: Compute probability distribution: 21.7643 seconds
QWindowsGLContext::makeCurrent: wglMakeCurrent() failed for existing context data (The requested resource is in use.)
A-tSNE: Set up offscreen buffer in 0.0003292 seconds.
Compute shader info log:
Compute shader info log:
A-tSNE: Init t-SNE 1.64604 seconds.
A-tSNE: Computing gradient descent..
C:/HDPS/Development/DevBundle/imaging_test/install/release/ManiVault Studio.exe (process 64252) exited with code -1073741571.
Contributor
Author
|
I've updated this with ifdef/ifndef APPLE to separate the macOS fix from the Windows & Linux functionality in TsneAnalysis.cpp |
ThomasKroes
approved these changes
Nov 22, 2023
ThomasKroes
left a comment
ThomasKroes
left a comment
Contributor
There was a problem hiding this comment.
Works perfectly on Win 11!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move initialization of the offscreenBuffer (which sets an openGL context to current) to the main thread. This fixes a macOS crash due to a UI operation not from the UI (main) thread