-
Notifications
You must be signed in to change notification settings - Fork 912
Update English Translations #23583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update English Translations #23583
Conversation
It looks like it's from https://www.github.com/webhippie/gettext_i18n_rails_js/pull/55... cc @kbrock I'm not sure what it was solving. The current patch we have is for the po to json side, not the code to po/pot side. https://github.com/ManageIQ/manageiq/blob/master/lib%2Ftasks%2Fpo_to_json_override.rb#L20-L47. I tried going to 2.0.0, which pulled in https://www.github.com/webhippie/po_to_json/pull/12 There was this but I can't find it now so I'll have to review it again and get see if we can get rid of some stuff. I was hoping it was simple but it's not so I'll have to look when I can dedicate more time to review all the various patches we have all over the place. We might have to revert back to 1.3.0 for now. |
3a5fd5d to
0ec0fe6
Compare
0ec0fe6 to
fd34956
Compare
fd34956 to
734a363
Compare
locale/en/manageiq.po
Outdated
| msgid "Depot Settings successfully validated" | ||
| msgstr "" | ||
|
|
||
| msgid "Depot Settings successfuly validated" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this one didn't go away
locale/en/manageiq.po
Outdated
| msgid "PXE Credentials successfully validated" | ||
| msgstr "" | ||
|
|
||
| msgid "PXE Credentials successfuly validated" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As well as this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's gone now.
734a363 to
9ebd171
Compare
9ebd171 to
e1fe67e
Compare
| msgid "Depot Settings validation failed" | ||
| msgstr "" | ||
|
|
||
| msgid "Depot Settings validation failed with error: %{error}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is still in FileDepotSmb
Update the English Translations in the manageiq.po and manageiq.pot files.