Skip to content

Conversation

@miq-bot
Copy link
Member

@miq-bot miq-bot commented Sep 15, 2025

Update the English Translations in the manageiq.po and manageiq.pot files.

@Fryguy
Copy link
Member

Fryguy commented Sep 15, 2025

@jrafanie These feel like the exact thing our PoToJson patch is supposed to prevent. I think this may have broken with the gem update in #23566

@jrafanie
Copy link
Member

@jrafanie These feel like the exact thing our PoToJson patch is supposed to prevent. I think this may have broken with the gem update in #23566

It looks like it's from https://www.github.com/webhippie/gettext_i18n_rails_js/pull/55... cc @kbrock

I'm not sure what it was solving. The current patch we have is for the po to json side, not the code to po/pot side. https://github.com/ManageIQ/manageiq/blob/master/lib%2Ftasks%2Fpo_to_json_override.rb#L20-L47. I tried going to 2.0.0, which pulled in https://www.github.com/webhippie/po_to_json/pull/12

There was this but I can't find it now so I'll have to review it again and get see if we can get rid of some stuff.

I was hoping it was simple but it's not so I'll have to look when I can dedicate more time to review all the various patches we have all over the place.

We might have to revert back to 1.3.0 for now.

@miq-bot miq-bot force-pushed the update_english_translations branch from 0ec0fe6 to fd34956 Compare October 15, 2025 00:26
@miq-bot miq-bot force-pushed the update_english_translations branch from fd34956 to 734a363 Compare October 22, 2025 14:39
msgid "Depot Settings successfully validated"
msgstr ""

msgid "Depot Settings successfuly validated"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this one didn't go away

msgid "PXE Credentials successfully validated"
msgstr ""

msgid "PXE Credentials successfuly validated"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as this one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's gone now.

@miq-bot miq-bot force-pushed the update_english_translations branch from 734a363 to 9ebd171 Compare November 1, 2025 00:31
@miq-bot miq-bot force-pushed the update_english_translations branch from 9ebd171 to e1fe67e Compare November 5, 2025 18:13
msgid "Depot Settings validation failed"
msgstr ""

msgid "Depot Settings validation failed with error: %{error}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is still in FileDepotSmb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants