Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for API Chunking support #146

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Updates for API Chunking support #146

merged 1 commit into from
Sep 20, 2019

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 19, 2019 •
edited by cben
Loading

Depends: ManageIQ/manageiq-providers-kubernetes#312

For future reference: VCR recorded with minishift running openshift 3.11.
Related fixes for future recordings #145

@miq-bot
Copy link
Member

miq-bot commented Sep 19, 2019

Checked commit agrare@116a09f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@agrare agrare changed the title Fix test_objects generation Updates for API Chunking support Sep 19, 2019
@agrare agrare closed this Sep 20, 2019
@agrare agrare reopened this Sep 20, 2019
@agrare
Copy link
Member Author

agrare commented Sep 20, 2019

Bouncing this to re-run with the core kube limit changes in

@agrare
Copy link
Member Author

agrare commented Sep 20, 2019

@cben 🍏

@cben cben merged commit 16955c1 into ManageIQ:master Sep 20, 2019
@agrare agrare deleted the updates_for_api_chunking branch September 20, 2019 14:03
@agrare
Copy link
Member Author

agrare commented Sep 20, 2019

🎉 thanks!

simaishi pushed a commit that referenced this pull request Sep 20, 2019
@cben @simaishi
Merge pull request #146 from agrare/updates_for_api_chunking
0737498 
Updates for API Chunking support

(cherry picked from commit 16955c1)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1754071
@simaishi
Copy link

Hammer backport details:

$ git log -1
commit 073749850c7e9cba80aa7c9e248cf1e2df36f5be
Author: Beni Cherniavsky-Paskin <[email protected]>
Date:   Fri Sep 20 16:59:07 2019 +0300

    Merge pull request #146 from agrare/updates_for_api_chunking
    
    Updates for API Chunking support
    
    (cherry picked from commit 16955c1aee9aec465468c3bbae6ac20509cffe6d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1754071

simaishi pushed a commit that referenced this pull request Nov 1, 2019
@cben @simaishi
Merge pull request #146 from agrare/updates_for_api_chunking
fcb95c2 
Updates for API Chunking support

(cherry picked from commit 16955c1)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767834
@simaishi
Copy link

simaishi commented Nov 1, 2019

Ivanchuk backport details:

$ git log -1
commit fcb95c2a2d2dd49772ae1e268345d7a01b728cef
Author: Beni Cherniavsky-Paskin <[email protected]>
Date:   Fri Sep 20 16:59:07 2019 +0300

    Merge pull request #146 from agrare/updates_for_api_chunking
    
    Updates for API Chunking support
    
    (cherry picked from commit 16955c1aee9aec465468c3bbae6ac20509cffe6d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cben cben cben approved these changes

Assignees

@cben cben

Labels
changelog/yes hammer/backported ivanchuk/backported performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @miq-bot @simaishi @cben