Assume role support for aws eks credentials #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Mar 28, 2024
addressed review comments
agrare
approved these changes
Apr 2, 2024
agrare
added a commit
to agrare/kubeclient
that referenced
this pull request
Jun 18, 2024
…support_for_aws_eks_credentials Assume role support for aws eks credentials (cherry picked from commit 9f95df3)
agrare
added a commit
to agrare/kubeclient
that referenced
this pull request
Jun 18, 2024
Added - Add test coverage for Ruby 3.2 (ManageIQ#615) - Allow a region when getting a signer for Aws::Sts (ManageIQ#507) - Update the AWS STS endpoint to be regional as the method is now regional (ManageIQ#528) - Assume role support for aws eks credentials (ManageIQ#630) Fixed - [v4.y] Regenerated expired test TLS certs by running `test/config/update_certs_k0s.rb`. - [v4.y] Regenerated expired test TLS certs (ManageIQ#611) - Regenerated expired test TLS certs (ManageIQ#632) Changed - Update actions/checkout (ManageIQ#590) - chore(deps): update actions/checkout action to v4 (ManageIQ#619)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using this kubeclient to perform API operations against the AWS EKS (kubernetes) clusters (i.e. the Kubernetes API Server). But we are not using access_key & secret_key directly as it is generally considered insecure. Hence we use - role based access control along with AWS STS to perform authentication (i.e. short lived temporary credentials). But the support for such Credentials Provider is not there in this Client (only supports - static Credentials & profile based static credentials).
I tried a small change to support the AssumeRoleCredentials Provider and it worked nicely. Hence I thought this would be a nice feature enhancement for this repo to users like me who want to use role based access with STS assumed role credentials.
Fixes #<id>formatNot a bug fix. It is a feature enhancement.