CI: run on windows? #553
Open
CI: run on windows? #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔴 ruby 2.5 to 3.0 fail with: 🔴 ruby 3.1, ruby-head, truffleruby-head pass |
|
Yay, windows now on parity with other platforms, all CRuby versions actually run the tests, and all passed except #569 🎉 (Well, except truffleruby-head which apparently has no windows builds? anyway that's not a blocker.) |
cben
force-pushed
the
ci-windows
branch
2 times, most recently
from
e887fe4 to
96be379
Compare
|
Force-pushed to use same rebased commits as #570. now macos 2.5 keeps timing out 😕 There is a warning that might or might not be related 🤷 :
I guess it's time to drop EOL Ruby 2.5 (and 2.6?) on master branch? |
|
cben
force-pushed
the
ci-windows
branch
4 times, most recently
from
5683753 to
6dd4df1
Compare
Hope this might fix "Error installing rake" errors. - https://github.com/ruby/setup-ruby#windows has some indications Windows needs particular versions of bundler to work well, and IIUC setup-ruby should already install bundler, so rely on that. - We do need rake but it's a kubeclient.gemspec dependency that `bundle install` should cover, avoid a global install with `gem`.
Needed on Windows: https://github.com/tzinfo/tzinfo/wiki/Resolving-TZInfo::DataSourceNotFound-Errors tzinfo is required by (at least) openid_connect gem, which is an "optional" dependency for kubeclient — users are supposed to bring it themselves if they use 'oidc' auth — so making tzinfo-data a dev dependency.
Personally, I wish we were using:
Style::TrailingCommaInHashLiteral:
EnforcedStyleForMultiline: consistent_comma
but that'd require 49 fixes, too much noise.
Don't know if it works, let's try :-) 'windows-latest` currently means Windows Server 2022 (https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/)
|
Bah, broke something in github actions file. I'm tempted to just leave non-existant (windows, truffleruby) combination in, but I think the rubocop job was already broken (it did not use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if it works, let's try :-)
'windows-latest` currently means Windows Server 2022
(https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/)