Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated exception #479

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove deprecated exception #479

wants to merge 1 commit into from

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Nov 16, 2020

No description provided.

@cben
Copy link
Collaborator

cben commented Nov 16, 2020

See my comment #293 (comment) on similar attempt.
I think we do want a base class (or module) that will cover all our exception non-http errors too.
However, it's good time to move it to our namespace e.g. Kubeclient::Error? I'll try to make an alternative PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grosser @cben