[v4.1.z] Fix underscores for non-suffix plurals #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not onto master! I've cut
v4.1.z
branch fromv4.1.0
tag and want to release this as 4.1.1, then merge this into master before doing anything else on master.Fixes #376, a regression in 4.1.0. Partially undoes 783c58b from #366.
Restores underscores in following method names (all of these prefixed with
get_
,create_
etc):These are the known examples from k8s and openshift (exact differences 4.0.0 -> 4.1.0 -> this PR can be seen in this gist).
In principle may similarly affect other plurals in custom resources, eg. (fictional) big_datum / big_data.
(duh, if only I carefully read the comments before that refactoring, they specifically showed
networkpolicies
plural and matching only onNetworkP
prefix...)WIP because need changelog & I want to add another test.