Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mention where px_per_unit needs to be used #4900

Merged
merged 1 commit into from
Apr 1, 2025
Merged

mention where px_per_unit needs to be used #4900

merged 1 commit into from
Apr 1, 2025

Conversation

ranocha
Copy link
Contributor

@ranocha ranocha commented Apr 1, 2025

Description

It was not clear where this keyword argument should be used and I lost some time trying to pass it to Figure.

Type of change

Improve documentation

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@SimonDanisch SimonDanisch added the skip-changelog Skips changelog enforcer label Apr 1, 2025
@SimonDanisch SimonDanisch merged commit 4279a42 into MakieOrg:master Apr 1, 2025
2 of 3 checks passed
@SimonDanisch
Copy link
Member

Thank you!

@ranocha ranocha deleted the patch-1 branch April 1, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip-changelog Skips changelog enforcer
Projects
PR review
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranocha @SimonDanisch