chore: Set some injected services to readonly

visualization/app/codeCharta/services/isAttributeSideBarVisible.service.ts

@@ -5,7 +5,7 @@ import { Injectable } from "@angular/core"
 export class IsAttributeSideBarVisibleService {
     isOpen = false
 
-    constructor(private threeSceneService: ThreeSceneService) {
+    constructor(private readonly threeSceneService: ThreeSceneService) {
         this.threeSceneService.subscribe("onBuildingSelected", () => {
             this.isOpen = true
         })

visualization/app/codeCharta/services/loadInitialFile/loadInitialFile.service.ts

@@ -68,11 +68,11 @@ export class LoadInitialFileService {
     private urlUtils = new UrlExtractor(this.httpClient)
 
     constructor(
-        private store: Store,
-        private state: State<CcState>,
-        private dialog: MatDialog,
-        private loadFileService: LoadFileService,
-        private httpClient: HttpClient
+        private readonly store: Store,
+        private readonly state: State<CcState>,
+        private readonly dialog: MatDialog,
+        private readonly loadFileService: LoadFileService,
+        private readonly httpClient: HttpClient
     ) {}
 
     async loadFilesOrSampleFiles() {

visualization/app/codeCharta/services/version/version.service.ts

@@ -8,7 +8,7 @@ import { compareVersion } from "./utils/compareVersion"
 export class VersionService {
     readonly version = packageJson.version
 
-    constructor(private dialog: MatDialog) {}
+    constructor(private readonly dialog: MatDialog) {}
 
     synchronizeLocalCodeChartaVersion() {
         const savedPreviousVersion = localStorage.getItem("codeChartaVersion")

visualization/app/codeCharta/state/effects/autoFitCodeMapChange/autoFitCodeMap.effect.ts

@@ -13,10 +13,10 @@ import { RenderCodeMapEffect } from "../renderCodeMapEffect/renderCodeMap.effect
 @Injectable()
 export class AutoFitCodeMapEffect {
     constructor(
-        private store: Store<CcState>,
-        private renderCodeMapEffect: RenderCodeMapEffect,
-        private threeMapControlsService: ThreeMapControlsService,
-        private actions$: Actions
+        private readonly store: Store<CcState>,
+        private readonly renderCodeMapEffect: RenderCodeMapEffect,
+        private readonly threeMapControlsService: ThreeMapControlsService,
+        private readonly actions$: Actions
     ) {}
 
     autoFitTo$ = createEffect(

visualization/app/codeCharta/state/effects/nodeContextMenu/excludeButton/excludeButton.component.ts

@@ -14,7 +14,7 @@ import { MatButton } from "@angular/material/button"
 export class ExcludeButtonComponent {
     @Input() codeMapNode: Pick<CodeMapNode, "path" | "type">
 
-    constructor(private store: Store) {}
+    constructor(private readonly store: Store) {}
 
     excludeNode() {
         this.store.dispatch(

visualization/app/codeCharta/state/effects/nodeContextMenu/flattenButtons/flattenButtons.component.ts

@@ -14,7 +14,7 @@ import { MatButton } from "@angular/material/button"
 export class FlattenButtonsComponent {
     @Input() codeMapNode: Pick<CodeMapNode, "path" | "type" | "isFlattened">
 
-    constructor(private store: Store) {}
+    constructor(private readonly store: Store) {}
 
     flattenNode() {
         this.store.dispatch(

visualization/app/codeCharta/state/effects/nodeContextMenu/focusButtons/focusButtons.component.ts

@@ -23,7 +23,7 @@ export class FocusButtonsComponent {
     currentFocusedNodePath$ = this.store.select(currentFocusedNodePathSelector)
     hasPreviousFocusedNodePath$ = this.store.select(focusedNodePathSelector).pipe(map(focusedNodePaths => focusedNodePaths.length > 1))
 
-    constructor(private store: Store<CcState>) {}
+    constructor(private readonly store: Store<CcState>) {}
 
     handleFocusNodeClicked() {
         this.store.dispatch(focusNode({ value: this.codeMapNode.path }))

visualization/app/codeCharta/state/effects/nodeContextMenu/markFolderRow/markFolderRow.component.ts

@@ -18,7 +18,7 @@ export class MarkFolderRowComponent {
     markFolderItems$ = this.store.select(markFolderItemsSelector)
     codeMapNode$ = this.store.select(rightClickedCodeMapNodeSelector)
 
-    constructor(private store: Store<CcState>) {}
+    constructor(private readonly store: Store<CcState>) {}
 
     markFolder(path: string, color: string) {
         this.store.dispatch(markPackages({ packages: [{ path, color }] }))

visualization/app/codeCharta/state/effects/nodeContextMenu/nodeContextMenuCard/nodeContextMenuCard.component.ts

@@ -35,7 +35,7 @@ import { LastPartOfNodePathPipe } from "./lastPartOfNodePath.pipe"
 export class NodeContextMenuCardComponent implements OnInit {
     codeMapNode$: Observable<CodeMapNode>
 
-    constructor(private store: Store<CcState>) {}
+    constructor(private readonly store: Store<CcState>) {}
 
     ngOnInit(): void {
         this.codeMapNode$ = this.store.select(rightClickedCodeMapNodeSelector)

visualization/app/codeCharta/state/effects/renderCodeMapEffect/renderCodeMap.effect.ts

@@ -16,11 +16,11 @@ export const maxFPS = 1000 / 60
 @Injectable()
 export class RenderCodeMapEffect {
     constructor(
-        private store: Store<CcState>,
-        private actions$: Actions,
-        private uploadFilesService: UploadFilesService,
-        private threeRendererService: ThreeRendererService,
-        private codeMapRenderService: CodeMapRenderService
+        private readonly store: Store<CcState>,
+        private readonly actions$: Actions,
+        private readonly uploadFilesService: UploadFilesService,
+        private readonly threeRendererService: ThreeRendererService,
+        private readonly codeMapRenderService: CodeMapRenderService
     ) {}
 
     private actionsRequiringRender$ = this.actions$.pipe(ofType(...actionsRequiringRerender))

visualization/app/codeCharta/state/effects/resetChosenMetrics/resetChosenMetrics.effect.ts

@@ -14,7 +14,7 @@ import { defaultNMetrics, isAnyMetricAvailable, preselectCombination } from "./u
 
 @Injectable()
 export class ResetChosenMetricsEffect {
-    constructor(private store: Store<CcState>) {}
+    constructor(private readonly store: Store<CcState>) {}
 
     resetChosenDistributionMetric$ = createEffect(
         () =>

visualization/app/codeCharta/state/effects/resetSelectedEdgeMetricWhenItDoesntExistAnymore/resetSelectedEdgeMetricWhenItDoesntExistAnymore.effect.ts

@@ -9,7 +9,7 @@ import { edgeMetricSelector } from "../../store/dynamicSettings/edgeMetric/edgeM
 
 @Injectable()
 export class ResetSelectedEdgeMetricWhenItDoesntExistAnymoreEffect {
-    constructor(private store: Store<CcState>) {}
+    constructor(private readonly store: Store<CcState>) {}
 
     resetSelectedEdgeMetricWhenItDoesntExistAnymore$ = createEffect(() =>
         this.store.select(metricDataSelector).pipe(

visualization/app/codeCharta/state/effects/unfocusNodes/unfocusNodes.effect.ts

@@ -8,7 +8,7 @@ import { CcState } from "../../../codeCharta.model"
 
 @Injectable()
 export class UnfocusNodesEffect {
-    constructor(private store: Store<CcState>) {}
+    constructor(private readonly store: Store<CcState>) {}
 
     unfocusNodes$ = createEffect(() => this.store.select(visibleFileStatesSelector).pipe(map(() => unfocusAllNodes())))
 }

visualization/app/codeCharta/state/effects/updateEdgePreviews/updateEdgePreviews.effect.ts

@@ -9,7 +9,7 @@ import { CcState } from "../../../codeCharta.model"
 
 @Injectable()
 export class UpdateEdgePreviewsEffect {
-    constructor(private store: Store<CcState>) {}
+    constructor(private readonly store: Store<CcState>) {}
 
     resetIsEdgeMetricVisible$ = createEffect(() =>
         this.store.select(edgeMetricSelector).pipe(

visualization/app/codeCharta/ui/attributeSideBar/attributeSideBarHeaderSection/attributeSideBarHeaderSection.component.ts

@@ -17,7 +17,7 @@ export class AttributeSideBarHeaderSectionComponent {
     @Input() node: Pick<CodeMapNode, "children" | "name" | "link" | "path">
     @Input() fileName: string
 
-    constructor(private isAttributeSideBarVisibleService: IsAttributeSideBarVisibleService) {}
+    constructor(private readonly isAttributeSideBarVisibleService: IsAttributeSideBarVisibleService) {}
 
     closeSideBar() {
         this.isAttributeSideBarVisibleService.isOpen = false

visualization/app/codeCharta/ui/attributeSideBar/attributeSideBarPrimaryMetrics/attributeSideBarPrimaryMetrics.component.ts

@@ -29,7 +29,7 @@ export class AttributeSideBarPrimaryMetricsComponent {
     showAttributeTypeSelector$: Observable<boolean>
     attributeDescriptors$: Observable<AttributeDescriptors>
 
-    constructor(private store: Store<CcState>) {
+    constructor(private readonly store: Store<CcState>) {
         this.primaryMetrics$ = this.store.select(primaryMetricsSelector)
         this.showAttributeTypeSelector$ = this.store.select(showAttributeTypeSelectorSelector)
         this.attributeDescriptors$ = this.store.select(attributeDescriptorsSelector)

visualization/app/codeCharta/ui/attributeSideBar/attributeSideBarSecondaryMetrics/attributeSideBarSecondaryMetrics.component.ts

@@ -26,7 +26,7 @@ export class AttributeSideBarSecondaryMetricsComponent {
     showDeltaValue$: Observable<boolean>
     attributeDescriptors$: Observable<AttributeDescriptors>
 
-    constructor(private store: Store<CcState>) {
+    constructor(private readonly store: Store<CcState>) {
         this.secondaryMetrics$ = this.store.select(secondaryMetricsSelector)
         this.showAttributeTypeSelector$ = this.store.select(showAttributeTypeSelectorSelector)
         this.showDeltaValue$ = this.store.select(showDeltaValueSelector)

visualization/app/codeCharta/ui/attributeSideBar/attributeTypeSelector/attributeTypeSelector.component.ts

@@ -18,7 +18,7 @@ export class AttributeTypeSelectorComponent {
 
     attributeTypes$ = this.store.select(attributeTypesSelector)
 
-    constructor(private store: Store<CcState>) {}
+    constructor(private readonly store: Store<CcState>) {}
 
     setToAbsolute() {
         this.setAttributeType(AttributeTypeValue.absolute)

visualization/app/codeCharta/ui/attributeSideBar/metricDeltaSelected/metricDeltaSelected.component.ts

@@ -20,7 +20,7 @@ export class MetricDeltaSelectedComponent implements OnInit {
     selectedNode$: Observable<CodeMapNode>
     mapColors$: Observable<MapColors>
 
-    constructor(private store: Store<CcState>) {}
+    constructor(private readonly store: Store<CcState>) {}
 
     ngOnInit(): void {
         this.selectedNode$ = this.store.select(selectedNodeSelector)

visualization/app/codeCharta/ui/codeMap/arrow/codeMap.arrow.service.ts

@@ -36,10 +36,10 @@ export class CodeMapArrowService implements OnDestroy {
         .subscribe()
 
     constructor(
-        private store: Store<CcState>,
-        private state: State<CcState>,
+        private readonly store: Store<CcState>,
+        private readonly state: State<CcState>,
         private threeSceneService: ThreeSceneService,
-        private idToBuildingService: IdToBuildingService
+        private readonly idToBuildingService: IdToBuildingService
     ) {
         this.threeSceneService.subscribe("onBuildingSelected", this.onBuildingSelected)
         this.threeSceneService.subscribe("onBuildingDeselected", this.onBuildingDeselected)

visualization/app/codeCharta/ui/codeMap/codeMap.component.ts

@@ -33,10 +33,10 @@ export class CodeMapComponent implements AfterViewInit, OnDestroy {
 
     constructor(
         public isAttributeSideBarVisibleService: IsAttributeSideBarVisibleService,
-        private store: Store<CcState>,
-        private threeViewerService: ThreeViewerService,
-        private codeMapMouseEventService: CodeMapMouseEventService,
-        private elementReference: ElementRef
+        private readonly store: Store<CcState>,
+        private readonly threeViewerService: ThreeViewerService,
+        private readonly codeMapMouseEventService: CodeMapMouseEventService,
+        private readonly elementReference: ElementRef
     ) {}
 
     ngAfterViewInit(): void {

visualization/app/codeCharta/ui/codeMap/codeMap.label.service.ts

@@ -34,10 +34,10 @@ export class CodeMapLabelService {
     private nodeHeight = 0
 
     constructor(
-        private state: State<CcState>,
-        private threeCameraService: ThreeCameraService,
+        private readonly state: State<CcState>,
+        private readonly threeCameraService: ThreeCameraService,
         private threeSceneService: ThreeSceneService,
-        private threeMapControlsService: ThreeMapControlsService
+        private readonly threeMapControlsService: ThreeMapControlsService
     ) {
         this.labels = new Array<InternalLabel>()
         this.threeMapControlsService.subscribe("onCameraChanged", () => this.onCameraChanged())

visualization/app/codeCharta/ui/codeMap/codeMap.mouseEvent.service.ts

@@ -79,12 +79,12 @@ export class CodeMapMouseEventService implements OnDestroy {
         private threeCameraService: ThreeCameraService,
         private threeRendererService: ThreeRendererService,
         private threeSceneService: ThreeSceneService,
-        private store: Store<CcState>,
-        private state: State<CcState>,
-        private codeMapLabelService: CodeMapLabelService,
-        private viewCubeMouseEvents: ViewCubeMouseEventsService,
-        private threeViewerService: ThreeViewerService,
-        private idToBuilding: IdToBuildingService
+        private readonly store: Store<CcState>,
+        private readonly state: State<CcState>,
+        private readonly codeMapLabelService: CodeMapLabelService,
+        private readonly viewCubeMouseEvents: ViewCubeMouseEventsService,
+        private readonly threeViewerService: ThreeViewerService,
+        private readonly idToBuilding: IdToBuildingService
     ) {}
 
     ngOnDestroy(): void {

visualization/app/codeCharta/ui/codeMap/codeMap.render.service.ts

@@ -27,8 +27,8 @@ export class CodeMapRenderService implements OnDestroy {
     private subscription: Subscription
 
     constructor(
-        private store: Store<CcState>,
-        private state: State<CcState>,
+        private readonly store: Store<CcState>,
+        private readonly state: State<CcState>,
         private threeSceneService: ThreeSceneService,
         private codeMapLabelService: CodeMapLabelService,
         private codeMapArrowService: CodeMapArrowService,

visualization/app/codeCharta/ui/codeMap/threeViewer/threeMapControls.service.ts

@@ -22,9 +22,9 @@ export class ThreeMapControlsService {
     zoomPercentage$ = new BehaviorSubject<number>(100)
 
     constructor(
-        private threeCameraService: ThreeCameraService,
-        private threeSceneService: ThreeSceneService,
-        private threeRendererService: ThreeRendererService
+        private readonly threeCameraService: ThreeCameraService,
+        private readonly threeSceneService: ThreeSceneService,
+        private readonly threeRendererService: ThreeRendererService
     ) {}
 
     setControlTarget(cameraTarget: Vector3) {