Skip to content

Update to use multi-phase module init in C #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update to use multi-phase module init in C #115

wants to merge 4 commits into from

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Oct 12, 2023

No description provided.

Copy link
Contributor

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid, but I think I do want to benchmark it before we merge it.

}

static int
map_node_bitmap_dump(MapNode_Bitmap *node,
map_node_bitmap_dump(map_module_state *state,
MapNode_Bitmap *node,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation error

@@ -310,23 +336,46 @@ typedef struct {
} MapNode_Collision;


static volatile uint64_t mutid_counter = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This probably didn't need to be volatile)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants