Add "Rendering Component" page #333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristjanESPERANTO
requested changes
Oct 22, 2025
| If `getDom` is not overridden, MagicMirror will try and render a | ||
| [Nunjucks](https://mozilla.github.io/nunjucks/) template from `getTemplate`. | ||
|
|
||
| Nunjucks is a templating language for Javascript. You can read more about the |
There was a problem hiding this comment.
Javascript -> JavaScript
|
I like this addition. Thank you! 🙂 About the syntax highlighting: I would stick with nunjucks. An additional thought on this: I wonder a little whether it would make sense to recommend the Two reasons:
I researched active alternatives, but everything I found would entail breaking changes. Currently, there isn't really a problem, but I suspect that one will arise in the long term. The last Nunjucks release was in 2023 – maybe I'm painting too early a picture of the devil on the wall here 😈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329
Adding a specific page on rending components, breaking down the
getDomandgetTemplateapproaches.Open to any suggestions!
One thing I've noticed is that there is no syntax highlighting for Nunjucks. Not sure if there is a straight forward fix for this, but I poked around and couldn't find anything.
The syntax is close enough to
twig, so we could use that, but then obviously the language tag in the upper right is incorrect.