fix: Preserve saved theme preference across sessions#186
fix: Preserve saved theme preference across sessions#186onedge wants to merge 1 commit intoMaciek-roboblog:mainfrom
Conversation
📝 WalkthroughWalkthroughThe conditional gating for automatic theme detection in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
--themeoption was not explicitly provided in the CLI, ignoring the saved preference inlast_used.jsonChanges
Modified:
src/claude_monitor/core/settings.pytheme == "auto"OR (theme not provided in CLI AND not clearing config) → auto-detecttheme == "auto"Problem Context
When a user runs
claude-monitor --theme dark, the preference is saved tolast_used.json. On the next run with justclaude-monitor(without theme option), the saveddarktheme should be used. However, the previous logic would switch to auto-detection mode simply because the theme was not provided in the CLI arguments.Test Plan
claude-monitor --theme darkto save dark themeclaude-monitor(without options) to verify dark theme persistsclaude-monitor --theme autoto verify auto-detection still works~/.claude-monitor/last_used.jsonSummary by CodeRabbit
Release Notes