Add new algo audio2midi #1437
Add new algo audio2midi #1437
Conversation
| if sys.platform == "darwin": | ||
| import soundfile as sf | ||
|
|
||
| audio, _ = sf.read(filename, dtype="float32") | ||
| if audio.ndim > 1: | ||
| audio = audio[:, 0] | ||
| else: | ||
| audio = MonoLoader(filename=filename, sampleRate=sample_rate)() |
There was a problem hiding this comment.
Use MonoLoader for both cases for consistency and also to avoid additional dependency.
There was a problem hiding this comment.
Right, but I'm running tests in OSX. So, I need it to run them. Once we resolve all comments I might remove it. Let's fix the other parts and I will do it.
There was a problem hiding this comment.
To be able to merge this now, let's get rid of the soundfile dependency and let the test temporarily fail on MacOS.
| n_notes_tolerance: int = 0, | ||
| onset_tolerance: float = 0.01, | ||
| offset_tolerance: float = 0.01, | ||
| midi_note_tolerance: int = 0, |
There was a problem hiding this comment.
This can be hardcoded inside asserts directly
There was a problem hiding this comment.
No, it cannot because it is inside runARealCase() which receive different values for those parameters. If we hardcoded some tests will fail. I can remove the default value, that would be okay.
There was a problem hiding this comment.
Please resolve or suggest any others changes.
| if sys.platform == "darwin": | ||
| import soundfile as sf | ||
|
|
||
| audio, _ = sf.read(filename, dtype="float32") | ||
| if audio.ndim > 1: | ||
| audio = audio[:, 0] | ||
| else: | ||
| audio = MonoLoader(filename=filename, sampleRate=sample_rate)() |
There was a problem hiding this comment.
To be able to merge this now, let's get rid of the soundfile dependency and let the test temporarily fail on MacOS.
It includes header, cpp and unittests.