Bug fix in line 56 for pitchcontour segmentation#1165
Open
cvf-bcn-gituser wants to merge 5 commits intoMTG:masterfrom
Open
Bug fix in line 56 for pitchcontour segmentation#1165cvf-bcn-gituser wants to merge 5 commits intoMTG:masterfrom
cvf-bcn-gituser wants to merge 5 commits intoMTG:masterfrom
Conversation
cvf-bcn-gituser
commented
Oct 28, 2021
Contributor
Author
cvf-bcn-gituser
left a comment
cvf-bcn-gituser
left a comment
There was a problem hiding this comment.
@dbogdanov , I have brought this branch up to date.
There are two small changes to be added for this PR.
Contributor
Author
|
Hello , @dbogdanov , @palonso I added two small important checks to pitchcontours.h/cpp and pitchcontoursegmentation.h. To verify nothing is broken in those small changes I added the two UT files that pass for me. Let me know if its OK, this will allow me to replicate other necessary changes on the other similar algorithms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor correction for the pitchcontour segmentation CPP file.
For Unit test file please refer to python files added in the following open PR:
#1137
There are more algorithm tests included in that PR.
In this pull request there is also a tiny documentation correction in pitch contours header file ("durig"-> "during")