DICOM: try to handle Siemens mosaic even if CSA fields missing#1061
DICOM: try to handle Siemens mosaic even if CSA fields missing#1061jdtournier wants to merge 6 commits intodevfrom
Conversation
thijsdhollander
left a comment
There was a problem hiding this comment.
Since not finalised yet, I propose to save it for a future release, or a hotfix.
|
@jdtournier: Did my best to resolve this with |
Old review from RC2 preparation days no longer relevant.
|
Is this still a goal for RC3? |
To be honest, I don't think it should be. It certainly shouldn't delay the release, and even if I do get around to implementing the remaining changes, it'll require testing to make sure nothing breaks. I'll give it a crack if I have a minute, but personally I think we should release ASAP regardless. |
|
If it requires any more than just running your DICOM import test script, then let's leave it out. |
|
OK, let's leave it out. For completeness, the testing I'd do is just to make sure it doesn't break existing well-formed data. I'd need additional testing to check that it can read malformed data correctly, but there's no reference data for that to test against. So yes, it's a bit of work... |
|
@jdtournier Will leave in |
a3ab965 to
83a4dd5
Compare
70031c3 to
6bf4cec
Compare
83a4dd5 to
a3ab965
Compare
see related discussion in #1012.
Is this worth considering including? Slight problem in that it requires a bit of work to finalise in order to throw out redundant slices, but should still be do-able relatively quickly...