Skip to content

DICOM: try to handle Siemens mosaic even if CSA fields missing#1061

Open
jdtournier wants to merge 6 commits intodevfrom
handle_siemens_mosaic_even_if_csa_information_missing
Open

DICOM: try to handle Siemens mosaic even if CSA fields missing#1061
jdtournier wants to merge 6 commits intodevfrom
handle_siemens_mosaic_even_if_csa_information_missing

Conversation

@jdtournier
Copy link
Copy Markdown
Member

see related discussion in #1012.

Is this worth considering including? Slight problem in that it requires a bit of work to finalise in order to throw out redundant slices, but should still be do-able relatively quickly...

@jdtournier jdtournier self-assigned this Jul 19, 2017
Copy link
Copy Markdown
Contributor

@thijsdhollander thijsdhollander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since not finalised yet, I propose to save it for a future release, or a hotfix.

@thijsdhollander thijsdhollander changed the base branch from tag_3.0_RC2 to dev August 8, 2017 02:32
@jdtournier jdtournier mentioned this pull request Sep 10, 2017
@Lestropie Lestropie added this to the Milestone 3.0_RC3 milestone Jan 17, 2018
@Lestropie Lestropie mentioned this pull request Jan 17, 2018
@Lestropie
Copy link
Copy Markdown
Member

@jdtournier: Did my best to resolve this with dev, but it will need your look-over / a run with your DICOM test suite / a test with scrubbed CSAs.

@thijsdhollander thijsdhollander dismissed their stale review March 2, 2018 10:46

Old review from RC2 preparation days no longer relevant.

@thijsdhollander
Copy link
Copy Markdown
Contributor

Is this still a goal for RC3?

@jdtournier
Copy link
Copy Markdown
Member Author

Is this still a goal for RC3?

To be honest, I don't think it should be. It certainly shouldn't delay the release, and even if I do get around to implementing the remaining changes, it'll require testing to make sure nothing breaks. I'll give it a crack if I have a minute, but personally I think we should release ASAP regardless.

@Lestropie Lestropie removed this from the Milestone 3.0_RC3 milestone Apr 26, 2018
@Lestropie
Copy link
Copy Markdown
Member

If it requires any more than just running your DICOM import test script, then let's leave it out.

@jdtournier
Copy link
Copy Markdown
Member Author

OK, let's leave it out.

For completeness, the testing I'd do is just to make sure it doesn't break existing well-formed data. I'd need additional testing to check that it can read malformed data correctly, but there's no reference data for that to test against. So yes, it's a bit of work...

@jdtournier jdtournier added this to the 3.0_RC4 release milestone Jan 30, 2019
@Lestropie
Copy link
Copy Markdown
Member

@jdtournier Will leave in 3.1.0 milestone pending a re-run through the DICOM test suite.

@Lestropie Lestropie force-pushed the handle_siemens_mosaic_even_if_csa_information_missing branch from a3ab965 to 83a4dd5 Compare August 26, 2025 07:47
@Lestropie Lestropie force-pushed the dev branch 2 times, most recently from 70031c3 to 6bf4cec Compare August 26, 2025 08:11
@Lestropie Lestropie force-pushed the handle_siemens_mosaic_even_if_csa_information_missing branch from 83a4dd5 to a3ab965 Compare August 29, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants