Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 24, 2025

Pillow 10.x is unavailable for Python 3.14, blocking support for newer Python versions. The constraint was unnecessarily tight.

Changes

  • pyproject.toml: Relaxed Pillow constraint from <11.0.0 to <13.0.0
  • dev-spec.txt: Matched constraint to <13.0.0
  • ci/recipe/meta.yaml: Matched constraint to <13.0.0

Testing

Verified Image.LANCZOS resizing in mpas_analysis/shared/html/image_xml.py (the only Pillow usage) works identically across versions 10.4.0, 11.3.0, and 12.0.0.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

Closes #1071

Original prompt

This section details on the original issue you should resolve

<issue_title>Support "pillow >=10.0.0,<13.0.0"</issue_title>
<issue_description>We are currently restricting pillow to a version that is not available for python 3.14. The restriction seems unnecessarily tight. We should look at where we are using pillow and what code changes are needed to support versions 11.x and 12.x. We should relax the constraint if at all possible.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@xylar
Copy link
Collaborator

xylar commented Nov 24, 2025

Copilot AI changed the title [WIP] Update pillow version constraint to support 11.x and 12.x Support Pillow >=10.0.0,<13.0.0 for Python 3.14 compatibility Nov 24, 2025
Copilot AI requested a review from xylar November 24, 2025 17:04
Copilot finished work on behalf of xylar November 24, 2025 17:04
Copy link
Contributor Author

Copilot AI commented Nov 24, 2025

@copilot, please also update:
https://github.com/MPAS-Dev/MPAS-Analysis/blob/develop/ci/recipe/meta.yaml#L43

Updated in 656a3f8. All three files (pyproject.toml, dev-spec.txt, and ci/recipe/meta.yaml) now consistently specify pillow >=10.0.0,<13.0.0.

Copilot finished work on behalf of xylar November 24, 2025 17:08
@xylar
Copy link
Collaborator

xylar commented Nov 24, 2025

I will run the test suite with this before I merge.

@xylar xylar mentioned this pull request Nov 24, 2025
2 tasks
@xylar xylar marked this pull request as ready for review November 24, 2025 19:56
@xylar
Copy link
Collaborator

xylar commented Nov 24, 2025

Testing

I ran the test suite on Chrysalis and all websites were produced as expected:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/xasaydavis/analysis_testing/chrysalis/copilot/support-pillow-versions-11-12/

@xylar xylar merged commit eea5436 into develop Nov 24, 2025
8 checks passed
@xylar xylar deleted the copilot/support-pillow-versions-11-12 branch November 24, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support "pillow >=10.0.0,<13.0.0"

2 participants