RemoveProductString: Código & Test #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fichero con las mejoras solicitadas en el test del método Order de MyBagManager. Comprueba que gestione el id unívoco y que borra la cesta tras los pedidos.
Test usado para probar mi implementación del método removeProduct(String). Test desarrollado por jorjimsan.
Fichero con la implementación pedida del método removeProduct(String) de MyBagManager.
Cambios solicitados en el método RemoveProduct(String) de MyBagManager.
Borro este test porque ha de entregarlo mi compañero.
Test desarrollado por mi compañero Jorjimsan al que se le han añadido las modificaciones pedidas.
|
El test automático falla pero los warnings que he visto no son de la parte nuestra del código (son errores en las definiciones de los imports). Por lo tanto, doy por concluida mi revisión a falta de que lo revise la profesora (como la otra revisora de este Pull Request). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se incluyen las nuevas versiones tanto del test como del código del método RemoveProduct(String) de MyBagManager.