Skip to content

Conversation

@mwinkel-dev
Copy link
Contributor

This fixes issue #2987.

Surprisingly, MATLAB does not return the same "class" type across all platforms. That caused the mdstest.m script to fail.

After the script was upgraded, it now passes all three bridges (Java, Python, mdsthin) on the following platforms.

  • Ubuntu 24, MATLAB R2025a, OpenJDK 21.0.8, Python 3.12.3, NumPy 1.26.4
  • macOS Tahoe, MATLAB R2024b, OpenJDK 21.0.8, Python 3.12.8, NumPy 2.2.2
  • Win11, MATLAB R2025b, Java 1.8.0_471, Python 3.12.12, NumPy 2.3.5

@mwinkel-dev mwinkel-dev self-assigned this Nov 25, 2025
@mwinkel-dev mwinkel-dev added bug An unexpected problem or unintended behavior api/matlab Relates to the Matlab API labels Nov 25, 2025
@mwinkel-dev mwinkel-dev marked this pull request as draft November 25, 2025 03:04
@mwinkel-dev
Copy link
Contributor Author

The mdstest.m script needs more work to use the mdsthin-bridge. Presently, the script is defaulting to the python-bridge even when the user requests use of the mdsthin-bridge.

@mwinkel-dev
Copy link
Contributor Author

mwinkel-dev commented Nov 25, 2025

CORRECTION:
Additional experiments prove that everything is working as intended. The source of the confusion is that the new documentation states that mdstest.m is testing the bridges, but in reality it is merely testing MATLAB to see if it is configured to access the Java and Python programming languages.

Note that mdstest.m does not establish an mdsip connection to a remote MDSplus archive server, thus none of the three bridges (Java, Python, mdsthin) is exercised.

If mdstest(true, true) remains in the new documentation, then the comment line about that should remain in mdstest.m, even though mdstest(true, true) is equivalent to mdstest(true).

Alternatively, if mdstest(true, true) is removed from the new documentation, then the associated comment line should be removed from mdstest.m.

% mdstest() % tests current bridge
% mdstest(0) % tests java bridge
% mdstest(1) % tests python bridge
% mdstest(1,1) % tests mdsthin bridge
Copy link
Contributor Author

@mwinkel-dev mwinkel-dev Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this mdstest(1,1) comment line be deleted or retained?

Note that this MATLAB script tests connection to the Java and Python languages; it does not establish a bridge connection via mdsip to a remote MDSplus archive server.

@mwinkel-dev mwinkel-dev marked this pull request as ready for review November 25, 2025 14:43
@mwinkel-dev
Copy link
Contributor Author

Retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api/matlab Relates to the Matlab API bug An unexpected problem or unintended behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant