Build: add hashbang to scripts that need them for opinionated packaging systems #2981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarnier
changed the title
heidthecamp
changed the title
Contributor
|
Hi @dgarnier -- Thanks for the PR. The changes look good to me. Stephen has a bunch of post-CMake PRs, so I defer to him regarding approval of the PR (and schedule for merging it to alpha). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew is quite opinionated about installing scripts in unix systems that are textual but do not have a hashbang (#!/bin/sh for example) start.
These are the offending files that won't have their permissions set to executable unless they are amended. These changes are inline with the other scripts, so making the entire system more self-consistent.