Build: test release builds to find optimizer issues #2980
Merged
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heidthecamp
requested review from
WhoBrokeTheBuild,
joshStillerman,
mwinkel-dev and
santorofer
Add stage for build and test release. Note: RelWithDebInfo only uses -O2 but this has found all optimizer issues so far.
WhoBrokeTheBuild
force-pushed
the
th-jenkins-test-release-build
branch
from
0776480 to
78a5393
Compare
Member
|
I'm considering if we should merge this despite the failures, since it doesn't cause the failures but does illuminate them, then we can work on solving the issues with PRs like #2983 |
Contributor
|
This PR looks good. |
WhoBrokeTheBuild
approved these changes
Nov 6, 2025
Member
WhoBrokeTheBuild
left a comment
WhoBrokeTheBuild
left a comment
There was a problem hiding this comment.
I'm approving this despite the failing tests, we should merge this now so we can sort out the failing tests that it found in other PRs
joshStillerman
pushed a commit
that referenced
this pull request
Nov 6, 2025
Add stage for build and test release. Note: RelWithDebInfo only uses -O2 but this has found all optimizer issues so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stage for build and test release.
Note:
RelWithDebInfoonly uses-O2but this has found all optimizer issues so far.