Build: Multithread IDL Tests #2780
Draft
+220
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhoBrokeTheBuild
added
build
WhoBrokeTheBuild
force-pushed
the
multithread-idl-tests
branch
from
de6e94b to
5c808ef
Compare
mwinkel-dev
reviewed
May 31, 2024
mwinkel-dev
previously approved these changes
May 31, 2024
Contributor
There was a problem hiding this comment.
Have confirmed that this refactoring of the IDL test suite is suitable for multi-threading of the "read" tests. So approving this PR.
There is a trivial formatting / style issue at line ~380 which is an extraneous blank line. It is OK to leave it "as is".
We'll likely have to run this multi-threaded read test for a week or so before we can be confident that the connection stress tests (60 to 100 connections per test case) won't clash when run in parallel.
WhoBrokeTheBuild
force-pushed
the
multithread-idl-tests
branch
from
5c808ef to
885bdf6
Compare
First attempt at multithreading the IDL tests TODO: The write tests still need a way to access mdsip, and now in parallel We'll probably use different shot numbers or something to that effect
WhoBrokeTheBuild
force-pushed
the
multithread-idl-tests
branch
from
885bdf6 to
5a68c38
Compare
mwinkel-dev
previously approved these changes
Jun 4, 2024
Contributor
mwinkel-dev
left a comment
mwinkel-dev
left a comment
There was a problem hiding this comment.
Re-approving this PR.
heidthecamp
force-pushed
the
multithread-idl-tests
branch
from
f86c68d to
cf5c57d
Compare
Contributor
|
This is currently in the cmake branch. The gains of adding this with our current jenkins set up is minimal while adding a lot of complexity. This will be merged with cmake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at multithreading the IDL tests
TODO: The write tests still need a way to access mdsip, and now in parallel
We'll probably use different shot numbers or something to that effect
This also moves the
testidvariable out of IDL and turns it into a parameter to each testThis lets us name the threads and output log files for each test individually
TODO: Output a JUnit XML to allow Jenkins to track these tests