Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final GSoC blog post and call for mentors #341

Merged
merged 33 commits into from
Jan 18, 2024

Conversation

jennaswa
Copy link
Contributor

@jennaswa jennaswa commented Nov 29, 2023

It would be great to share all of the great work @xhgchen and @marinegor did during this year's GSoC program. Would you both be comfortable sharing .md files of your final project reports to be posted on the MDAnalysis blog and linked in this post? If so, it'd be great if you could please add your reports as blog posts as indicated in the README for this repo: https://github.com/MDAnalysis/MDAnalysis.github.io#blog-mdanalysisorgblog and add the appropriate links to the skeleton provided here. Thanks!

@jennaswa jennaswa added Blog blog content and articles GSoC work in progress labels Dec 23, 2023
@jennaswa
Copy link
Contributor Author

jennaswa commented Jan 5, 2024

I have added 2023 mentors/org admins as reviewers to this PR once @xhgchen and @marinegor have had the chance to add their final project reports.

@marinegor
Copy link

hi @jennaswa , sorry for the huge delay in this.
If I understood you correctly, this file should be enough: https://github.com/marinegor/marinegor.github.io/blob/master/_posts/2023-07-30-GSOC-6.md

I could add that as a separate PR, if needed.

@jennaswa
Copy link
Contributor Author

Thank you, @marinegor and @xhgchen for sending me your final submission files! To match our blog formatting, I've edited the formatting of your files slightly and signed with your GH handles at the bottom. Please review and approve if everything looks okay. I'd love to try to merge this tomorrow! :)

@marinegor
Copy link

hi @jennaswa , it looks fine -- the only thing is that I think it makes sense to add link to the page with previous posts on "previous posts" in the first paragraph, since the reader isn't on my blog page now (I added a comment).

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhgchen could you please review the installation instructions for transport analysis — it currently says "no release" and "install from source" but there's actually a 0.1.0 available that is pip-installable. Could we please also add some links to MDAKit things? We worked hard on MDAKits and would like to show that the infrastructure is being used.

@marinegor could you please look at one comment about the commented out select line in the RMSD calculation?

Otherwise I have various comments/suggestions — please implement as you see fit @jennaswa .

Thanks a lot for pulling it finally together!!

_posts/2024-01-11-gsoc2023_marinegor.md Outdated Show resolved Hide resolved
_posts/2024-01-11-gsoc2023_marinegor.md Outdated Show resolved Hide resolved
_posts/2024-01-11-gsoc2023_xhgchen.md Outdated Show resolved Hide resolved
_posts/2024-01-11-gsoc2023_xhgchen.md Outdated Show resolved Hide resolved
_posts/2024-01-11-gsoc2023_xhgchen.md Outdated Show resolved Hide resolved
_posts/2024-01-11-gsoc2023_xhgchen.md Outdated Show resolved Hide resolved
_posts/2024-01-11-gsoc2023_xhgchen.md Outdated Show resolved Hide resolved
_posts/2024-01-11-gsoc2023_xhgchen.md Outdated Show resolved Hide resolved
_posts/2024-01-11-gsoc2023_xhgchen.md Outdated Show resolved Hide resolved
_posts/2024-01-11-gsoc2023_xhgchen.md Outdated Show resolved Hide resolved
@xhgchen
Copy link
Member

xhgchen commented Jan 16, 2024

@xhgchen could you please review the installation instructions for transport analysis — it currently says "no release" and "install from source" but there's actually a 0.1.0 available that is pip-installable. Could we please also add some links to MDAKit things? We worked hard on MDAKits and would like to show that the infrastructure is being used.

@marinegor could you please look at one comment about the commented out select line in the RMSD calculation?

Otherwise I have various comments/suggestions — please implement as you see fit @jennaswa .

Thanks a lot for pulling it finally together!!

I see the new mention of MDAKits at the beginning and I think it is a nice edit - feel free to add any more MDAKit mentions/links as you feel is appropriate.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for addressing my comments so I am giving it a ✅ from my end.

@RMeli is raising some excellent points but I let him make a blocking review if necessary.

@jennaswa
Copy link
Contributor Author

jennaswa commented Jan 17, 2024

I believe all requested changes have now been addressed (please confirm @RMeli). Thank you for your help with this, everyone!

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jennaswa

@jennaswa jennaswa merged commit ef08b11 into MDAnalysis:master Jan 18, 2024
1 check passed
@orbeckst
Copy link
Member

Thanks for completing this big triple-post! But looking at https://www.mdanalysis.org/2024/01/11/gsoc2023_xhgchen/ , there seem to be plots not showing:

I think the actual PNG files were not committed. Can you please fix this @xhgchen ?

@jennaswa
Copy link
Contributor Author

jennaswa commented Jan 18, 2024 via email

@orbeckst
Copy link
Member

Looking in the actions workflow https://github.com/MDAnalysis/MDAnalysis.github.io/actions/runs/7573031005/job/20624240225 under "Build with Jekyll" shows the error:

  Liquid Exception: Could not find post "2024-01-11-gsoc2023_marinegor" in tag 'post_url'. Make sure the post exists and the name is correct. in /github/workspace/_posts/2024-01-18-gsoc2023-final.md
             ERROR: YOUR SITE COULD NOT BE BUILT:
                    ------------------------------------
                    Could not find post "2024-01-11-gsoc2023_marinegor" in tag 'post_url'. Make sure the post exists and the name is correct. 

Let me fix this ....

@orbeckst
Copy link
Member

I checked my fix locally and it looked fine so I just pushed to the master branch in 73356f8. Hopefully all good now 🤞

@jennaswa
Copy link
Contributor Author

Aha - I see where I forgot to update the dates to the individual posts now. Thanks for fixing this, @orbeckst !

OK, this is roughly 4 times faster! Amazing, roughly as we expected.
Spoiler though -- if we do it with 16 workers, we'll see the total time around 40 seconds, so improvement saturates at some point.

But, we've lost something valuable when switching to `multiprocessing` -- we don't have a decent progressbar anymore. Luckily, we can use an amazing `dask` dashboard that allows us to monitor all tasks given to a particular `dask.distributed` cluster!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marinegor - I just noticed that dask.distributed is still mentioned here and L130, although it was removed from other places. Should it remain here? If not, please tell me exactly what needs to be removed/replaced, or open a PR to make the necessary change. Thanks!

@jennaswa jennaswa deleted the gsoc-final branch February 2, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blog blog content and articles GSoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants