Skip to content

Ordinal Encoder added to the preprocessing module#21

Open
pachecoreina wants to merge 9 commits into
MBrouns:mainfrom
vvandermeij:feature/ordinal_encoder
Open

Ordinal Encoder added to the preprocessing module#21
pachecoreina wants to merge 9 commits into
MBrouns:mainfrom
vvandermeij:feature/ordinal_encoder

Conversation

@pachecoreina
Copy link
Copy Markdown

OrdinalEncoder added to the preprocessing module

The code that counts the feature:category occurrences is now a function that both OneHotEncoder and OrdinalEncoder use.

The function get_feature_names in utils was refactor to add dtype = None as a parameter so it accepts all types of data.

@MBrouns
Copy link
Copy Markdown
Owner

MBrouns commented Aug 14, 2022

Thanks for the PR! In the test_preprocessing.py file there's a test_standard_checks function that runs a bunch of the default scikit-learn checks on the OneHotEncoder. Could you make a similar function for the OrdinalEncoder?

@pachecoreina
Copy link
Copy Markdown
Author

Thanks for the PR! In the test_preprocessing.py file there's a test_standard_checks function that runs a bunch of the default scikit-learn checks on the OneHotEncoder. Could you make a similar function for the OrdinalEncoder?

Pushed a new commit with the standards checks for the OrdinalEncoder. Also added LabelEncoder and its tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants