Skip to content

Category bugfix onehotencoder #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vvandermeij wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Category bugfix onehotencoder #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6475202
bugfix implemented
Aug 11, 2022
01e837e
deleted_notebook
Aug 11, 2022
c8a6aa2
add_test for bugfix
Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/skprometheus/preprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def transform(self, X):

for idx, row in enumerate(categories.T):
for category in row:
if not category:
if category is None:
category = "missing"
MetricRegistry.model_categorical(feature=str(features[idx]), category=str(category)).inc()

Expand Down
1 change: 1 addition & 0 deletions tests/test_preprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ def test_OneHotEncoder():

assert REGISTRY.get_sample_value('skprom_model_categorical_total', {'feature': '2', 'category': '4'}) == 2
assert REGISTRY.get_sample_value('skprom_model_categorical_total', {'feature': '3', 'category': '9'}) == 1
assert REGISTRY.get_sample_value('skprom_model_categorical_total', {'feature': '3', 'category': '0'}) == 1


def test_OneHotEncoder_pandas():
Expand Down