Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate higher min cmake to tests #1997

Merged

Conversation

bradgrantham-lunarg
Copy link
Contributor

  • lower some cmake min versions where possible
  • put the higher cmake min in tests

* lower some cmake min versions where possible
* put the higher cmake min in tests
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 358641.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5954 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5954 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 358748.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5956 running.

Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work to raise the minimum where its needed without affecting build compatibility elsewhere.

@bradgrantham-lunarg bradgrantham-lunarg merged commit f2edac6 into LunarG:dev Jan 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants