gfxrecon-info now prints vulkan physical device info #1992
Conversation
|
CI gfxreconstruct build queued with queue ID 356651. |
|
CI gfxreconstruct build # 5933 running. |
|
CI gfxreconstruct build # 5933 passed. |
| @@ -56,6 +58,26 @@ class VulkanStatsConsumer : public gfxrecon::decode::VulkanConsumer | |||
| uint64_t GetAllocationCount() const { return allocation_count_; } | |||
| uint64_t GetMinAllocationSize() const { return min_allocation_size_; } | |||
| uint64_t GetMaxAllocationSize() const { return max_allocation_size_; } | |||
| void GetPhysicalDeviceProperties(uint32_t& api_version, | |||
There was a problem hiding this comment.
nit: not a big fun of output parameters, I would introduce a new struct to group these.
| @@ -377,6 +399,30 @@ class VulkanStatsConsumer : public gfxrecon::decode::VulkanConsumer | |||
| ++dispatch_count_; | |||
| } | |||
|
|
|||
| virtual void ProcessSetDevicePropertiesCommand(format::HandleId physical_device_id, | |||
There was a problem hiding this comment.
There will be one of these for every VkPhysicalDevice enumerated from an Instance so this needs to handle multiple SetDevicePropertiesCommand blocks. I have a .gfxr here with 2 of those blocks, one for an AMD discrete GPU and another for the integrated Intel GPU, so the blocks can't be assumed to have the same values.
There was a problem hiding this comment.
should be fixed now
panos-lunarg
force-pushed
the
gfxrecon_info_print_physical_device_info
branch
from
a88b7df to
e7bca07
Compare
|
CI gfxreconstruct build queued with queue ID 363259. |
|
CI gfxreconstruct build # 6001 running. |
|
CI gfxreconstruct build # 6001 passed. |
panos-lunarg
force-pushed
the
gfxrecon_info_print_physical_device_info
branch
from
e7bca07 to
13bfdc2
Compare
|
CI gfxreconstruct build queued with queue ID 364168. |
|
CI gfxreconstruct build # 6004 running. |
No description provided.