Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trim with external formats #1942

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

ziga-lunarg
Copy link
Contributor

Closes #1901

Replaces #1695

This only fixes the crash, there is a Todo left that is waiting on #1812

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 336995.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5690 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 337014.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5691 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5691 failed.

@bradgrantham-lunarg bradgrantham-lunarg requested review from antonio-lunarg and removed request for bradgrantham-lunarg January 7, 2025 17:23
@bradgrantham-lunarg
Copy link
Contributor

I've removed myself from reviewers for this one instance. If @mikes-lunarg and @antonio-lunarg approve the PR, please merge it.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 340003.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5721 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5721 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 341613.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5759 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5759 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 347088.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5823 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5823 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 348956.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5852 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5852 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 366647.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6024 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6024 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 366665.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6025 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6025 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 366686.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6026 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 6026 passed.

@ziga-lunarg ziga-lunarg merged commit 6bd7123 into LunarG:dev Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android games that use AHB will crash on trim
5 participants