Uniform behavior for measurements in FpsInfo
#1495
Conversation
|
CI gfxreconstruct build queued with queue ID 166370. |
|
CI gfxreconstruct build # 3999 running. |
marius-pelegrin-arm
force-pushed
the
uniform-measurements-behavior
branch
from
70bb92f to
d081beb
Compare
|
CI gfxreconstruct build queued with queue ID 166386. |
|
CI gfxreconstruct build # 4000 running. |
|
CI gfxreconstruct build # 4000 passed. |
marius-pelegrin-arm
force-pushed
the
uniform-measurements-behavior
branch
from
d081beb to
ca6b079
Compare
|
CI gfxreconstruct build queued with queue ID 175703. |
|
CI gfxreconstruct build # 4065 running. |
marius-pelegrin-arm
force-pushed
the
uniform-measurements-behavior
branch
from
ca6b079 to
53b5445
Compare
|
CI gfxreconstruct build queued with queue ID 175715. |
|
CI gfxreconstruct build # 4066 running. |
|
CI gfxreconstruct build # 4066 passed. |
marius-pelegrin-arm
force-pushed
the
uniform-measurements-behavior
branch
from
53b5445 to
ee92f48
Compare
|
CI gfxreconstruct build queued with queue ID 361709. |
|
CI gfxreconstruct build # 5999 running. |
Having uniform/standardized log formats/behaviors allow for automation tools to be easier to implement and maintain. As the measurements done by GFXReconstruct are performance free and were already done on the whole replay if no frame-range was specified, I propose to consider gfxrecon-replay as always acquiring measurements, either on the whole replay or on the specified frame-range. Thus there is no need for special message/behavior depending if a frame-range has been manually specified. That's what this commit implements: - A measurement file is always created if the replay has been run successfully - The same log message at the end of the replay is displayed, no matter if a range has been specified or not and no matter how much time the (potentially inexistant) load has taken In addition, as CLOCK_MONOTONIC has an arbitrary starting point, CLOCK_BOOTTIME start/end time have been added to the measurement file. Also, for measurement of CPU load, it's better to have a clock that measures process time instead of absolute time, so CLOCK_PROCESS_CPUTIME_ID start/end time have been added to the measurement file. Change-Id: I79edf334cbb7382233be7c5a3d07251294d0565f
marius-pelegrin-arm
force-pushed
the
uniform-measurements-behavior
branch
from
ee92f48 to
8793414
Compare
|
CI gfxreconstruct build queued with queue ID 361724. |
|
CI gfxreconstruct build # 6000 running. |
|
CI gfxreconstruct build # 6000 passed. |
|
A measurement file is always created if the replay has been run successfully why is it necessary to set as default? |
Having uniform/standardized log formats/behaviors allow for automation tools to be easier to implement and maintain.
As the measurements done by GFXReconstruct are performance free and were already done on the whole replay if no frame-range was specified, I propose to consider
gfxrecon-replayas always acquiring measurements, either on the whole replay or on the specified frame-range.Thus there is no need for special message/behavior depending if a frame-range has been manually specified. That's what this commit implements:
In addition, as
CLOCK_MONOTONIChas an arbitrary starting point,CLOCK_BOOTTIMEstart/end time have been added to the measurement file for time to be coherent between multiple runs ofgfxrecon-replay