Fix the null pointer issue for State Object for trim capture. #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 118690. |
|
CI gfxreconstruct build # 3679 running. |
bradgrantham-lunarg
approved these changes
Jan 18, 2024
|
CI gfxreconstruct build # 3679 passed. |
davidd-lunarg
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It has been found that the AddRef and Release calls are missing for State Objects, for trim capture only. During the replay, some State Objects may end up being released before they are used again by SetPipelineState1. If this happens, the replay will crash.
Solution
Add WriteAddRefAndReleaseCommands in Dx12StateWriter::WriteStateObjectsState.
Result
The potential crash will be avoided.