Fix memory exception during memcpy in ApplyBatchedResourceInitInfo #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the line that assign value to resource_init_info.subresource_sizes, this is because the subresource size will be assigned by ApplyFillMemoryResourceValueCommand
|
Author xooiamd not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI gfxreconstruct build queued with queue ID 103029. |
davidd-lunarg
approved these changes
Dec 18, 2023
|
CI gfxreconstruct build # 3628 running. |
|
CI gfxreconstruct build # 3628 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory exception happen due to the subresource_sizes.size() is not equal to layout_sizes.size(). This is because subresource_size has been set twice in Dx12ReplayConsumerBase::ProcessInitSubresourceCommand .
Thus, this PR removes the line resource_init_info.subresource_sizes = subresource_sizes; The subresource size will be set only by SetResourceInitInfoState .