Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra Error Handling in Convert Main #1378

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Extra Error Handling in Convert Main #1378

wants to merge 4 commits into from

Conversation

andrew-lunarg
Copy link
Contributor

@andrew-lunarg andrew-lunarg commented Dec 1, 2023 •
edited
Loading

Checking of file operation return values and exiting if file per frame and stdout options clash.

@andrew-lunarg andrew-lunarg added the convert Issue with convert execution or output label Dec 1, 2023
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 93093.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3579 running.

andrew-lunarg
andrew-lunarg commented Dec 1, 2023
View reviewed changes
@andrew-lunarg andrew-lunarg mentioned this pull request Dec 1, 2023
Merged
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3579 passed.

@andrew-lunarg andrew-lunarg force-pushed the andy-enhance-better-d3d12-convert-bonus03-file-op-return-value-checks-in-convert branch from 179e6a7 to 9c90f62 Compare December 2, 2023 00:11
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 93480.

@andrew-lunarg
Copy link
Contributor Author

I rebased it on latest dev so it can be merged and think it is ready.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3584 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3584 aborted.

@andrew-lunarg andrew-lunarg force-pushed the andy-enhance-better-d3d12-convert-bonus03-file-op-return-value-checks-in-convert branch from 9c90f62 to 9ad78b5 Compare December 2, 2023 00:34
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 93495.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3585 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3585 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 99184.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3613 running.

charles-lunarg
charles-lunarg approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and removed the use of goto since it wasn't consistent with the other tools.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3613 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 275991.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 275992.

@bradgrantham-lunarg bradgrantham-lunarg added the P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash. label Oct 10, 2024
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5033 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5033 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-lunarg charles-lunarg charles-lunarg approved these changes

@bradgrantham-lunarg bradgrantham-lunarg Awaiting requested review from bradgrantham-lunarg

Assignees
No one assigned
Labels
convert Issue with convert execution or output P2 A high-priority code maintenance issue or a functional problem that is recoverable or not a crash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew-lunarg @ci-tester-lunarg @charles-lunarg @bradgrantham-lunarg