Check whether ANDROID_SERIAL was set when working with multiple devices #1305
Conversation
|
CI gfxreconstruct build queued with queue ID 60238. |
|
CI gfxreconstruct build # 3373 running. |
|
CI gfxreconstruct build # 3373 failed. |
|
CI gfxreconstruct build queued with queue ID 60443. |
|
The build failure in #3373 was due to an unexpected GPU crash. I've restarted the run. Sorry for the inconvenience. |
|
CI gfxreconstruct build # 3376 running. |
1 similar comment
|
CI gfxreconstruct build # 3376 running. |
|
CI gfxreconstruct build # 3376 passed. |
bradgrantham-lunarg
added
the
P2
android/scripts/gfxrecon.py
Outdated
| if extras: | ||
| if args.push_file: | ||
| cmd = ' '.join([adb_push, args.push_file, args.file]) | ||
| if selection is not None: |
There was a problem hiding this comment.
this looks like an error, where was selection defined?
There was a problem hiding this comment.
Hey, thank you for the catch. Not sure how exactly this PR was left in this state, but I guess I forgot to remove those remnants of the previous approach. I will change it in the next commit.
android/scripts/gfxrecon.py
Outdated
| if extras: | ||
| if args.push_file: | ||
| cmd = ' '.join([adb_push, args.push_file, args.file]) | ||
| if selection is not None: | ||
| cmd = InsertDeviceSelectionArgument(cmd, selection) |
There was a problem hiding this comment.
where is InsertDeviceSelectionArgument coming from?
There was a problem hiding this comment.
Hey, thank you for the catch. Not sure how exactly this PR was left in this state, but I guess I forgot to remove those remnants of the previous approach. I will change it in the next commit.
|
CI gfxreconstruct build queued with queue ID 343668. |
|
CI gfxreconstruct build # 5770 running. |
|
CI gfxreconstruct build # 5770 failed. |
…ere are multiple This change is needed as when more than one device is connected, the script crashes if the selection is not explicitly specified. This change fixes it by adding a possibility to specify the device. Change-Id: I053b6962c5026f5fc9e3c3b97934f37a30431114
This change is needed as when more than one device is connected, the script crashes if the selection is not explicitly specified. This change makes the error message more transparent and suggests the way to fix it. Change-Id: I380bc619fe468dcbcd7f39e4171ab4146c2c8bab
Change-Id: I8d5ce4dd039a93a791fb079ea6ab709b732c39e0
If the adb server was not started yet, the output from adb devices would contain the adb start log, which caused device selection failure when single device attached. This change fixes that Change-Id: If4f15729aa9bb2b3f5ae8d49cf77089079c4b2f0
Change-Id: Ie535ae17087f348bb0b053bc8b4df4212c300d1e
MarkY-LunarG
force-pushed
the
feature-device-selection-option
branch
from
ebb08a5 to
7b830a6
Compare
|
CI gfxreconstruct build queued with queue ID 360044. |
|
Rebased on dev |
|
CI gfxreconstruct build # 5979 running. |
|
CI gfxreconstruct build # 5979 passed. |
Added a check whether the ANDROID_SERIAL was set.
This change is needed as when more than one device is connected, the script crashes if the selection is not explicitly specified. This change makes the error message more transparent and suggests the way to fix it.