-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add used resolutions info #1167
Add used resolutions info #1167
Conversation
Author bartosz-muszarski-arm not on autobuild list. Waiting for curator authorization before starting CI build. |
Could this be accomplished by a script parsing the output of |
CI gfxreconstruct build queued with queue ID 2227. |
CI gfxreconstruct build # 2896 running. |
As an example, here's a
|
CI gfxreconstruct build # 2896 passed. |
Yes, the same data can be generated from a json-converted trace. I would argue this is still more convenient to use on a daily basis. We use the resolution information along with application name and total frame count which we get from gfxrecon-info already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except if there are no swapchains created (e.g. vulkaninfo
) then the output is Used resolutions
and then nothing else. I think there should be no output if resolution.size() == 0
.
Okay, sounds good to me. I added a note about empty |
CI gfxreconstruct build queued with queue ID 6518. |
CI gfxreconstruct build # 2983 running. |
CI gfxreconstruct build # 2983 failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the one thought about vulkan.hpp.
Also your branch is failing in our internal CI because it's missing commit 32496a2 committed to dev
on June 29. If you rebase on current dev
I think it will probably pass our internal CI. Sorry, I think these are the last two items; thanks for being patient and sticking with us!
CI gfxreconstruct build queued with queue ID 10777. |
CI gfxreconstruct build # 3020 running. |
CI gfxreconstruct build # 3020 failed. |
gfxrecon-info reports resolutions used in vulkan traces based on data provided in vkCreateSwapchainKHR and vkCreateSharedSwapchainsKHR calls. Change-Id: I91118d1c7749662765d45e180c61937dd0297816
Change-Id: If09c70784503e4344bab2a3294245505027874ab
85db555
to
9a8d28d
Compare
CI gfxreconstruct build queued with queue ID 359743. |
CI gfxreconstruct build # 5967 running. |
CI gfxreconstruct build # 5967 failed. |
CI gfxreconstruct build queued with queue ID 359780. |
CI gfxreconstruct build # 5969 running. |
CI gfxreconstruct build # 5969 passed. |
gfxrecon-info reports resolutions used in vulkan traces based on data provided in vkCreateSwapchainKHR and vkCreateSharedSwapchainsKHR calls.
Sample output: