Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add used resolutions info #1167

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

bartosz-muszarski-arm
Copy link
Contributor

gfxrecon-info reports resolutions used in vulkan traces based on data provided in vkCreateSwapchainKHR and vkCreateSharedSwapchainsKHR calls.

Sample output:

Exe info:
        Application exe name: 
        Application version: 0.0.0.0
        Application Company name: 
        Product name: 
File info:
        Compression format: LZ4
        Total frames: 11

Application info:
        Application name: ray_queries
        Application version: 0
        Engine name: Vulkan Samples
        Engine version: 0
        Target API version: 4198400 (1.1.0)
        Used resolutions: 1280x720

Physical device info:
        Device name: NVIDIA GeForce RTX 2060
        Device ID: 0x1e89
        Vendor ID: 0x10de
        Driver version: 2181955968 (0x820e0180)
        API version: 4206797 (1.3.205)

Device memory allocation info:
        Total allocations: 12
        Min allocation size: 3932160
        Max allocation size: 134217728

Pipeline info:
        Total graphics pipelines: 2
        Total compute pipelines: 0

@ci-tester-lunarg
Copy link

Author bartosz-muszarski-arm not on autobuild list. Waiting for curator authorization before starting CI build.

@bradgrantham-lunarg
Copy link
Contributor

Could this be accomplished by a script parsing the output of convert?

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 2227.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2896 running.

@bradgrantham-lunarg
Copy link
Contributor

As an example, here's a jq line that extracts the imageExtent dimensions from vkCreateSwapchainKHR.

$ jq-win64.exe '.[] | select(.function.name == "vkCreateSwapchainKHR") | [.function.args.pCreateInfo.imageExtent.width,.function.args.pCreateInfo.imageExtent.height]' < gfxrecon_capture_20230428T153938.json
[
  500,
  500
]

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2896 passed.

@bartosz-muszarski-arm
Copy link
Contributor Author

Yes, the same data can be generated from a json-converted trace. I would argue this is still more convenient to use on a daily basis. We use the resolution information along with application name and total frame count which we get from gfxrecon-info already.

Copy link
Contributor

@bradgrantham-lunarg bradgrantham-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except if there are no swapchains created (e.g. vulkaninfo) then the output is Used resolutions and then nothing else. I think there should be no output if resolution.size() == 0.

@bradgrantham-lunarg
Copy link
Contributor

Yes, the same data can be generated from a json-converted trace. I would argue this is still more convenient to use on a daily basis. We use the resolution information along with application name and total frame count which we get from gfxrecon-info already.

Okay, sounds good to me. I added a note about empty resolutions but with that change we'll merge.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 6518.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2983 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 2983 failed.

Copy link
Contributor

@bradgrantham-lunarg bradgrantham-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the one thought about vulkan.hpp.

Also your branch is failing in our internal CI because it's missing commit 32496a2 committed to dev on June 29. If you rebase on current dev I think it will probably pass our internal CI. Sorry, I think these are the last two items; thanks for being patient and sticking with us!

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 10777.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3020 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3020 failed.

bartosz-muszarski-arm and others added 3 commits January 29, 2025 13:03
gfxrecon-info reports resolutions used in vulkan traces based on
data provided in vkCreateSwapchainKHR and vkCreateSharedSwapchainsKHR
calls.

Change-Id: I91118d1c7749662765d45e180c61937dd0297816
Change-Id: If09c70784503e4344bab2a3294245505027874ab
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 359743.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5967 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5967 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 359780.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5969 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5969 passed.

@MarkY-LunarG MarkY-LunarG merged commit 8928427 into LunarG:dev Jan 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants