Skip to content

Commit

Permalink
Don't check output format for raw format requests
Browse files Browse the repository at this point in the history
For a dump image raw request, don't fail if we don't know
how to encode the image data, as the raw write is bypassing
the write data.
  • Loading branch information
dfriederich committed Feb 10, 2025
1 parent c7e0e7d commit a4eafa2
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions framework/decode/vulkan_replay_dump_resources_common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -540,9 +540,12 @@ VkResult DumpImageToFile(const VulkanImageInfo* image_info,
image_file_format,
dump_image_raw);

const util::imagewriter::DataFormats image_writer_format = VkFormatToImageWriterDataFormat(dst_format);
assert(image_writer_format != util::imagewriter::DataFormats::kFormat_UNSPECIFIED);

util::imagewriter::DataFormats image_writer_format = util::imagewriter::DataFormats::kFormat_UNSPECIFIED;
if (output_image_format != KFormatRaw)
{
image_writer_format = VkFormatToImageWriterDataFormat(dst_format);
assert(image_writer_format != util::imagewriter::DataFormats::kFormat_UNSPECIFIED);
}
for (uint32_t mip = 0; mip < image_info->level_count; ++mip)
{
for (uint32_t layer = 0; layer < image_info->layer_count; ++layer)
Expand Down Expand Up @@ -629,10 +632,12 @@ VkResult DumpImageToFile(const VulkanImageInfo* image_info,
}
else
{
GFXRECON_LOG_WARNING(
"%s format is not handled. Images with that format will be dump as a plain binary file.",
util::ToString<VkFormat>(image_info->format).c_str());

if (!dump_image_raw)
{
GFXRECON_LOG_WARNING(
"%s format is not handled. Images with that format will be dump as a plain binary file.",
util::ToString<VkFormat>(image_info->format).c_str());
}
util::bufferwriter::WriteBuffer(filename, data.data(), data.size());
}

Expand Down

0 comments on commit a4eafa2

Please sign in to comment.