Skip to content

HTTPS support #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

HTTPS support #163

wants to merge 12 commits into from

Conversation

@monoid
Copy link
Contributor

@monoid monoid commented Jun 15, 2025

Closes #58.

@monoid monoid force-pushed the https-mock branch 2 times, most recently from f7bbbb7 to 37d2455 Compare June 23, 2025 14:39
@monoid monoid marked this pull request as ready for review June 23, 2025 14:39
@monoid
Copy link
Contributor Author

monoid commented Jun 30, 2025

@LukeMathWalker should I fix the clippy warnings in the old code in a separate PR?

@konstin konstin mentioned this pull request Sep 10, 2025
Merged
@Sytten
Copy link

Sytten commented Oct 22, 2025

It would be nice to merge that

@monoid
Copy link
Contributor Author

monoid commented Oct 22, 2025

It would be nice to merge that

It seems https://crates.io/crates/httpmock does support HTTPS.

monoid added 12 commits October 22, 2025 23:41
@monoid
TLS certificate generation
1490f8e
@monoid
Bare server generalized implementation
add9a5c 
It gets an additional argument `acceptor` that can represent either
ordinary TCP or TLS connection.
@monoid
Fix MockServer::uri()
d281e3f 
An HTTPS server's uri start with https protocol.
@monoid
First working TLS test example
1144113
@monoid
client cert test
04d1722
@monoid
Refactor: use MockServerTlsConfig
fe8fc6f 
Use it instead of `RustlsConfig` in the public API.
@monoid
Make clippy happy
641d5a7
@monoid
Docs and refactorings
f31c550
@monoid
Fix Cargo.toml
086e439
@monoid
make fmt happy
2bb902d
@monoid
Improve MockServerBuilder::build_bare_https
8fd9e69 
Extend its docstring and make `.expect` message clearer.
@monoid
Use axum-server to avoid duplicate deps
c11807c 
hyper-server is not updated and uses old deps.
@LukeMathWalker
Copy link
Owner

LukeMathWalker commented Oct 23, 2025

Thanks for the PR—unfortunately, it'll take me a while to get to review it.

@Sytten
Copy link

Sytten commented Oct 23, 2025

One thing is that we dont need axum-server for sure, tokio_rustls is enough for wiremock

@monoid
Copy link
Contributor Author

monoid commented Oct 23, 2025 •
edited
Loading

One thing is that we dont need axum-server for sure, tokio_rustls is enough for wiremock

wiremock's main uses hyper-server which was originally a fork of axum-server and is not maintained anymore (last release was two years ago). axum-server is a lean dependency, it is not whole axum. But I can revert the last commit if you wish.

@Sytten
Copy link

Sytten commented Oct 23, 2025

I dont see that as a dep here: https://github.com/LukeMathWalker/wiremock-rs/blob/main/Cargo.toml
That is all I am saying, I dont know enough about the project

@monoid
Copy link
Contributor Author

monoid commented Oct 23, 2025

I dont see that as a dep here

You are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTTPS support

3 participants

@monoid @Sytten @LukeMathWalker