Changed asset paths to relative to dir#2
Open
Lockszmith-GH wants to merge 1 commit intoLukaHarambasic:masterfrom
Open
Changed asset paths to relative to dir#2Lockszmith-GH wants to merge 1 commit intoLukaHarambasic:masterfrom
Lockszmith-GH wants to merge 1 commit intoLukaHarambasic:masterfrom
Conversation
Assets were all on root, which didn't work from a sub-dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this one, I really like the dark/light mode trick.
I decided to self host it, but in a subdir, the assets were all pointing to the root path of the hosted website.
This should continue to work as intented regadless of the path on the host.