refactor: open graph 중복되는 이슈 수정 #103
Draft
+32
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/clelab/clelab-frontend/4qmJ8SC1skZTh2kZLgRmFWMYEQkk |
evan-moon
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내용
기존에 설정되어있던 OpenGraph가 main에서 선언된 값에 중복되는 이슈를 수정했습니다.
특별히 봐줬으면 하는 부분
참고 사항
현재 meta tag seo 모듈화 하는 작업중인데
구현은 다 끝났는데 ssr 렌더시에 data가 없어서 못불러오는 이슈가 있어요! 요것을 해결하려면 전부 getServerSideProps 를 사용해서 데이터를 미리 불러온다음에 meta tag에 들어갈 데이터를 넣어줘야할것같은데 한 브랜치에서 생각보다 작업이 커질거같아서 일단 feature살려두고 branch 하나 새로 파서 ssr 작업 먼저 진행하겠습니다
https://swr.vercel.app/docs/with-nextjs
요 내용 참고해서 SSR시에 api fetch해서 default Data 만든다음에 meta tag에 들어갈 data를 default Data를 바로 바라볼 수 있게 작업할 예정이에요!