Skip to content

Add compile and lint ci#167

Open
AndrewNolte wants to merge 2 commits intoLramseyer:mainfrom
AndrewNolte:AndrewNolte/stack/9
Open

Add compile and lint ci#167
AndrewNolte wants to merge 2 commits intoLramseyer:mainfrom
AndrewNolte:AndrewNolte/stack/9

Conversation

@AndrewNolte
Copy link
Copy Markdown
Contributor

@AndrewNolte AndrewNolte commented Mar 27, 2026

@AndrewNolte AndrewNolte force-pushed the AndrewNolte/stack/9 branch from b73e2d2 to 723eaf9 Compare March 27, 2026 18:38
@AndrewNolte AndrewNolte marked this pull request as draft March 27, 2026 18:46
@AndrewNolte AndrewNolte marked this pull request as ready for review March 27, 2026 18:47
@AndrewNolte AndrewNolte marked this pull request as draft March 27, 2026 18:48
@AndrewNolte AndrewNolte force-pushed the AndrewNolte/stack/9 branch from 723eaf9 to 83f0d44 Compare March 27, 2026 18:48
@AndrewNolte AndrewNolte marked this pull request as ready for review March 27, 2026 18:48
@AndrewNolte AndrewNolte marked this pull request as draft March 27, 2026 18:57
@AndrewNolte AndrewNolte force-pushed the AndrewNolte/stack/9 branch from 83f0d44 to 951801e Compare March 27, 2026 18:57
@AndrewNolte AndrewNolte marked this pull request as ready for review March 27, 2026 18:57
@AndrewNolte
Copy link
Copy Markdown
Contributor Author

I think ci just needs a rerun; if not I can combine this with the following pr. It could perhaps be hitting some type inference bug in eslint that the following pr happens to fix.

stack-info: PR: Lramseyer#167, branch: AndrewNolte/stack/9
@AndrewNolte AndrewNolte marked this pull request as draft March 27, 2026 20:19
@AndrewNolte AndrewNolte force-pushed the AndrewNolte/stack/9 branch from 951801e to c9bd646 Compare March 27, 2026 20:19
@AndrewNolte AndrewNolte marked this pull request as ready for review March 27, 2026 20:19
@Lramseyer
Copy link
Copy Markdown
Owner

Let me go fix the issue in viewer_provider.ts. I'll let you know once the fix is in place.

@Lramseyer
Copy link
Copy Markdown
Owner

OK, you will want to update this PR, and remove the changes to viewer_provider.ts, and it should work.

Signed-off-by: Lloyd Ramseyer <laramseyer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants