Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the View implementation of
DotLottieAnimation, state machine event listeners are not properly registered.When
DotLottieAnimation.addStateMachineEventListener()is called,mLottieDrawablehas not yet been initialized and remainsnull. As a result, the state machine event listener is never forwarded to the underlying DotLottieDrawable instance.This issue specifically breaks
dotlottie-flutter, causing all state machine-related callbacks to stop functioning, asdotlottie-flutterintegrates with the Android View version rather than the Compose component.Solution
Following the existing pattern used for
dotLottieEventListener:DotLottieAnimation.mStateMachineEventListenerwhenaddStateMachineEventListener()is invoked.DotLottieDrawablelater.This ensures that
pollAndDispatchAllEvents()can successfully retrieve and dispatch events to the registered state machine listeners.