Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Мап мап #389

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Мап мап #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions Resources/Prototypes/_LostParadise/Maps/Pools/LostParadiseMapPool.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
- type: gameMapPool
id: LostParadiseMapPool
maps:
# - LPPAsterisk
# - LPPSubmarine
# - LPPPebble
- LPPAsterisk
- LPPSubmarine
- LPPPebble
# - LPPNormandy
# - LPPKerberos
# - LPPIceBox
# - LPPCyberiad
- LPPKerberos
- LPPIceBox
- LPPCyberiad
# - Plot_113
- NY_LPPAsterisk
# - NY_LPPAsterisk
- LPPSubmarine
- NY_PebbleStation
- NY_LPPNormandy
- NY_LPPKerberos
# - NY_PebbleStation
# - NY_LPPNormandy
# - NY_LPPKerberos
- LPPIceBox
- NY_Plot_113
- NY_LPPCyberiad
# - NY_Plot_113
# - NY_LPPCyberiad

Comment on lines +4 to +20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Обнаружены дублирующиеся записи карт

В конфигурации пула карт обнаружены дублирующиеся записи:

  • LPPSubmarine (строки 5 и 13)
  • LPPIceBox (строки 9 и 17)

Рекомендуется удалить дублирующиеся записи во избежание непредвиденного поведения при ротации карт.

  - LPPAsterisk
  - LPPSubmarine
  - LPPPebble
#  - LPPNormandy
  - LPPKerberos
  - LPPIceBox
  - LPPCyberiad
#  - Plot_113
#  - NY_LPPAsterisk
-  - LPPSubmarine
#  - NY_PebbleStation
#  - NY_LPPNormandy
#  - NY_LPPKerberos
-  - LPPIceBox
#  - NY_Plot_113
#  - NY_LPPCyberiad
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- LPPAsterisk
- LPPSubmarine
- LPPPebble
# - LPPNormandy
# - LPPKerberos
# - LPPIceBox
# - LPPCyberiad
- LPPKerberos
- LPPIceBox
- LPPCyberiad
# - Plot_113
- NY_LPPAsterisk
# - NY_LPPAsterisk
- LPPSubmarine
- NY_PebbleStation
- NY_LPPNormandy
- NY_LPPKerberos
# - NY_PebbleStation
# - NY_LPPNormandy
# - NY_LPPKerberos
- LPPIceBox
- NY_Plot_113
- NY_LPPCyberiad
# - NY_Plot_113
# - NY_LPPCyberiad
- LPPAsterisk
- LPPSubmarine
- LPPPebble
# - LPPNormandy
- LPPKerberos
- LPPIceBox
- LPPCyberiad
# - Plot_113
# - NY_LPPAsterisk
# - NY_PebbleStation
# - NY_LPPNormandy
# - NY_LPPKerberos
# - NY_Plot_113
# - NY_LPPCyberiad
🧰 Tools
🪛 yamllint (1.35.1)

[error] 4-4: wrong indentation: expected at least 3

(indentation)

[warning] 7-7: comment not indented like content

(comments-indentation)

[warning] 11-11: comment not indented like content

(comments-indentation)

[warning] 14-14: comment not indented like content

(comments-indentation)

[error] 20-20: too many blank lines

(1 > 0) (empty-lines)

2 changes: 1 addition & 1 deletion Resources/Prototypes/_LostParadise/Maps/asterisk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
id: LPPAsterisk
mapName: 'Астериск'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Обнаружены русские переводы в прототипе

Согласно правилам кодирования, в прототипах запрещены переводы на русский язык. Необходимо использовать только английский текст или ссылки на переводы.

-  mapName: 'Астериск'
+  mapName: 'Asterisk'
   ...
-          mapNameTemplate: '{0} Станция Астериск {1}'
+          mapNameTemplate: '{0} Station Asterisk {1}'

Also applies to: 16-16

mapPath: /Maps/_LostParadise/LPPAsterisk.yml
minPlayers: 20
minPlayers: 0
maxPlayers: 70
stations:
LPPAsterisk:
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/_LostParadise/Maps/cyberiad.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
id: LPPCyberiad
mapName: 'NS Кибериада'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Обнаружены русские переводы в прототипе

Согласно правилам кодирования, в прототипах запрещены переводы на русский язык. Необходимо использовать только английский текст или ссылки на переводы.

-  mapName: 'NS Кибериада'
+  mapName: 'NS Cyberiad'
   ...
-          mapNameTemplate: '{0} NS Кибериада {1}'
+          mapNameTemplate: '{0} NS Cyberiad {1}'

Also applies to: 11-11

mapPath: /Maps/_LostParadise/LPPCyberiad.yml
minPlayers: 20
minPlayers: 15
stations:
LPPCyberiad:
stationProto: StandardNanotrasenStation
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/_LostParadise/Maps/icebox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
id: LPPIceBox
mapName: 'NTS АйсБокс'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Обнаружены русские переводы в прототипе

Согласно правилам кодирования, в прототипах запрещены переводы на русский язык. Необходимо использовать только английский текст или ссылки на переводы.

-  mapName: 'NTS АйсБокс'
+  mapName: 'NTS IceBox'
   ...
-          mapNameTemplate: '{0} NTS АйсБокс {1}'
+          mapNameTemplate: '{0} NTS IceBox {1}'

Also applies to: 11-11

mapPath: /Maps/_LostParadise/LPPIceBox.yml
minPlayers: 15
minPlayers: 0
stations:
IceBoxstation:
stationProto: StandardNanotrasenStation
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/_LostParadise/Maps/kerberos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
id: LPPKerberos
mapName: 'NS Керберос'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Обнаружены русские переводы в прототипе

Согласно правилам кодирования, в прототипах запрещены переводы на русский язык. Необходимо использовать только английский текст или ссылки на переводы.

-  mapName: 'NS Керберос'
+  mapName: 'NS Kerberos'
   ...
-          mapNameTemplate: '{0} NS Керберос {1}'
+          mapNameTemplate: '{0} NS Kerberos {1}'

Also applies to: 11-11

mapPath: /Maps/_LostParadise/LPPKerberos.yml
minPlayers: 30
minPlayers: 15
stations:
LPPKerberos:
stationProto: StandardNanotrasenStation
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/_LostParadise/Maps/submarine.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
id: LPPSubmarine
mapName: 'Субмарина'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо использовать английский язык в прототипах

Согласно правилам кодирования, в прототипах запрещены переводы на русский язык. Замените русский текст на английский или добавьте ссылку на перевод для следующих строк:

  • mapName: 'Субмарина'
  • mapNameTemplate: '{0} Субмарина {1}'

Also applies to: 11-11

mapPath: /Maps/_LostParadise/LPPSubmarine.yml
minPlayers: 60
minPlayers: 15
stations:
LPPSubmarine:
stationProto: StandardNanotrasenStation
Expand Down
Loading