Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Новогодние штучки #364

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Новогодние штучки #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79f9f1b
НГ обнова
BL02DL Dec 27, 2024
d42ba77
переводы
BL02DL Dec 27, 2024
fd8a955
фиксы
BL02DL Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .../Locale/en-US/ss14-ru/prototypes/_lostparadise/entities/structures/wallmounts/newyear.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
ent-LPPNewYearSocksRed = socks
.desc = hanging socks on the wall, like you should put gifts there...
ent-LPPNewYearSocksGreen = socks
.desc = hanging socks on the wall, like you should put gifts there...
ent-LPPNewYearSocksOrange = socks
.desc = hanging socks on the wall, like you should put gifts there...
ent-LPPNewYearBell = new year bell
.desc = New Year's bell with a wreath, festive mood..
ent-LPPCandyNewYear = candy
.desc = A New Year's candy that feels like the end of the past.
ent-LPPLightbulbsNewYear = light bulbs
.desc = Hanging garland, not the best source of light
Comment on lines +1 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Необходимо скорректировать регистр согласно требованиям к переводам, начинающимся с ent-.

Согласно вашим руководствам, все переводы, ключ которых начинается с ent-, должны идти с заглавной буквы после знака «=», включая описание .desc. Например:

-ent-LPPNewYearSocksRed = socks
-    .desc = hanging socks on the wall, like you should put gifts there...
+ent-LPPNewYearSocksRed = Socks
+    .desc = Hanging socks on the wall, like you should put gifts there...

Аналогично нужно применить к остальным строкам (стр. 1-12).

Committable suggestion skipped: line range outside the PR's diff.

ent-LPPPresentRandom = present
.desc = A New Year's gift, I wonder what's in it!
.suffix = Filled Safe
15 changes: 15 additions & 0 deletions .../Locale/ru-RU/ss14-ru/prototypes/_lostparadise/entities/structures/wallmounts/newyear.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
ent-LPPNewYearSocksRed = носок
.desc = Новогодний носок, как будто туда надо класть подарки...
ent-LPPNewYearSocksGreen = носок
.desc = Новогодний носок, как будто туда надо класть подарки...
ent-LPPNewYearSocksOrange = носок
.desc = Новогодний носок, как будто туда надо класть подарки...
ent-LPPNewYearBell = new year bell
.desc = Новогодний колокольчик с венком, праздничное настроение..
ent-LPPCandyNewYear = конфетка
.desc = Новогодняя конфета, которая напоминает о конце прошлого.
ent-LPPLightbulbsNewYear = гирлянда
.desc = Новогодняя гирлянда озаряющая красками нового года.
Comment on lines +1 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Следует привести текст к заглавной букве после «=» для ключей, начинающихся с ent-.

По вашим гайдлайнам переводы вида ent-... должны быть с заглавной буквы. Также описания .desc должны начинаться с заглавной. Например:

-ent-LPPNewYearSocksRed = носок
-    .desc = Новогодний носок, как будто туда надо класть подарки...
+ent-LPPNewYearSocksRed = Носок
+    .desc = Новогодний носок, как будто туда надо класть подарки...

Committable suggestion skipped: line range outside the PR's diff.

ent-LPPPresentRandom = подарок
.desc = Новогодний подарок, интересно что же внутри!
.suffix = безопасный
2 changes: 1 addition & 1 deletion Resources/Prototypes/Entities/Objects/Decoration/present.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- type: Sprite
sprite: Objects/Decoration/present.rsi
layers:
- state: present
- state: present

- type: entity
id: Present
Expand Down
10 changes: 5 additions & 5 deletions Resources/Prototypes/_LostParadise/Entities/Objects/Consumable/food/halloween.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
- type: RandomSprite
available:
- enum.DamageStateVisualLayers.Base:
candy_1: Material
candy_2: Material
candy_3: Material
candy_4: Material
candy_1: Material
candy_2: Material
candy_3: Material
candy_4: Material
- type: Item
size: Tiny
shape:
Expand All @@ -33,4 +33,4 @@
Quantity: 1
- type: Tag
tags:
- LPPCandy
- LPPCandy
2 changes: 1 addition & 1 deletion Resources/Prototypes/_LostParadise/Entities/Structures/Wallmounts/halloween.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
parent: BaseSign
id: LPPPCheckboxes
name: checkboxes
description: Black and orange flags, it's got a halloween feel to it.
description: Black and orange flags, it's got a halloween feel to it.
components:
- type: Sprite
sprite: _LostParadise/Structures/Wallmounts/halloween.rsi
Expand Down
Loading
Loading