Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_certs workflow and Fastlane lane for Distribution certificate management #228

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Add check_certs workflow and Fastlane lane for Distribution certificate management #228

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5dd137d
Add check_certs workflow and Fastlane lane for Distribution certifica…
bjornoleh Jan 9, 2025
0a9d876
check_certs.yml: use checkout@v4
bjornoleh Jan 9, 2025
aa0115b
Don't nuke certs in warning period, add optional vars.FORCE_NUKE_CERTS
bjornoleh Jan 9, 2025
4e8ed2e
Require check_certs before building
bjornoleh Jan 9, 2025
063d602
Set error when no valid certs and ENABLE_NUKE_CERTS is not 'true'.
bjornoleh Jan 9, 2025
5432ec6
Annotation for valid certs
bjornoleh Jan 9, 2025
12628fe
Refine error annotations for Validate Fastlane Secrets
bjornoleh Jan 11, 2025
90cc934
Remove unused env
bjornoleh Jan 12, 2025
fd9acda
Refactor GitHub Actions Workflows and Fastlane Configuration
bjornoleh Jan 13, 2025
9b8ef46
Rename to "3. Check Certificates", delete old create_certificates.yml
bjornoleh Jan 13, 2025
b6bb80a
validate_secrets annotation improvement
bjornoleh Jan 13, 2025
634bbae
Rename to original names create_certs.yml name: 3. Create Certificates
bjornoleh Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/validate_secrets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ jobs:
failed=true
echo "::error::Unable to create a valid authorization token for the App Store Connect API."
echo "::error::❗️ Verify that the latest developer program license agreement has been accepted at https://developer.apple.com/account (review and accept any updated agreement), then wait a few minutes for changes to take effect and try again."
echo "::error::❗️ Also verify that the FASTLANE_ISSUER_ID, FASTLANE_KEY_ID, and FASTLANE_KEY secrets are set correctly and try again."
echo "::error::❗️ If you created a new FASTLANE KEY or have not previously succeeded with validate secrets, then check that FASTLANE_ISSUER_ID, FASTLANE_KEY_ID, and FASTLANE_KEY secrets were entered correctly."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marionbarker , was this what you had in mind?

fi
fi

Expand Down