Skip to content

fix: use pathlib.Path for save_path #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lachlangrose merged 2 commits into from
May 1, 2025
Merged

fix: use pathlib.Path for save_path #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e2e799
fix: accept pathlib.Path for save_path
rabii-chaarani Apr 23, 2025
ff23f45
fix: allow str and pathlib.Path
lachlangrose May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions map2loop/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ def draw_geology_map(self, points: pandas.DataFrame = None, overlay: str = ""):
gdf.plot(ax=base, marker="o", color="red", markersize=5)

@beartype.beartype
def save_mapdata_to_files(self, save_path: str = ".", extension: str = ".shp.zip"):
def save_mapdata_to_files(self, save_path: Union[pathlib.Path,str], extension: str = ".shp.zip"):
"""
Saves the map data frames to csv files

Expand All @@ -1022,8 +1022,10 @@ def save_mapdata_to_files(self, save_path: str = ".", extension: str = ".shp.zip
extension (str, optional):
An alternate extension to save the GeoDataFrame in. Defaults to ".csv".
"""
if not os.path.exists(save_path):
os.mkdir(save_path)

save_path=pathlib.Path(save_path)
if not save_path.exists():
os.makedirs(save_path)
self.map_data.save_all_map_data(save_path, extension)

@beartype.beartype
Expand Down