Skip to content

perf: optimize _peer_to_session from std::map to std::unordered_map #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaowyc wants to merge 4 commits into
base: master
Choose a base branch
from
Open

perf: optimize _peer_to_session from std::map to std::unordered_map #4415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd36d82
perf: optimize _peer_to_session from std::map to std::unordered_map
chaowyc Nov 12, 2025
75153ca
Merge pull request #1 from chaowyc/optimize-peer-to-session-map
chaowyc Nov 12, 2025
17f7f07
fix: correct append_struct reserve calculation and optimize insertion
chaowyc Nov 12, 2025
8934dd1
Merge pull request #2 from chaowyc/perf-optimize-append-struct
chaowyc Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/stream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ namespace stream {
sync_util::sync_t<std::vector<session_t *>> _sessions;

// ENet peer to session mapping for sessions with a peer connected
sync_util::sync_t<std::map<net::peer_t, session_t *>> _peer_to_session;
sync_util::sync_t<std::unordered_map<net::peer_t, session_t *>> _peer_to_session;

ENetAddress _addr;
net::host_t _host;
Expand Down
7 changes: 2 additions & 5 deletions src/utility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,13 +202,10 @@ namespace util {
void append_struct(std::vector<uint8_t> &buf, const T &_struct) {
constexpr size_t data_len = sizeof(_struct);

buf.reserve(data_len);
buf.reserve(buf.size() + data_len); // Reserve enough space upfront

auto *data = (uint8_t *) &_struct;

for (size_t x = 0; x < data_len; ++x) {
buf.push_back(data[x]);
}
buf.insert(buf.end(), data, data + data_len);
}

template<class T>
Expand Down
Loading