fix: Add graceful shutdown for web server and tray #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 60.70% 66.97% +6.27%
==========================================
Files 14 15 +1
Lines 397 539 +142
==========================================
+ Hits 241 361 +120
- Misses 156 178 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ReenigneArcher
force-pushed
the
fix/properly-terminate-threads
branch
12 times, most recently
from
544d343 to
d4372f1
Compare
Introduces a new signal_handler module providing ShutdownSignal and ShutdownCoordinator for managing graceful shutdown across threads. Refactors main entry point, tray, and web modules to support coordinated shutdown using these primitives. Adds async and sync thread registration, monitoring, and timeout-based forced exit. Includes comprehensive unit and integration tests for shutdown coordination and signal handling.
Replaces the FORCE_EXIT_DISABLED static and related methods with a configurable exit function in ShutdownCoordinator. This enables tests to inject a no-op or custom exit handler, improving testability and removing Windows-specific test logic. Updates all relevant tests to use the new constructor with a mock exit function.
ReenigneArcher
force-pushed
the
fix/properly-terminate-threads
branch
from
b48756b to
b1ac6e0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced a ShutdownSignal utility for coordinated shutdown across threads. The web server and tray now support graceful shutdown, with the main function orchestrating thread lifecycles and timeouts. Added dependencies on ctrlc and tokio to support async shutdown handling.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage