Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple-icons to bring it the latest icons #1794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pho3nixf1re
Copy link

@pho3nixf1re pho3nixf1re commented Jan 28, 2025

pho3nixf1re Quick pho3nixf1re /update-simple-icons → Lissy93/dashy Commits: 1 | Files Changed: 2 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

Category:

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (please specify)

Dependency update

Overview

Briefly outline your new changes...

Updates the simple-icons package to bring in the latest icons. Unfortunately this is a "breaking" change in that some icons have been removed due to legal reasons (notably the Adobe suite and Nintendo icons). I'm not sure if this counts as breaking for this project. I could argue either way.

@Lissy93 would you please recommend a version bump that is appropriate for this change?

Issue Number (if applicable) #00

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency or devDependency, please outline here

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@pho3nixf1re pho3nixf1re requested a review from Lissy93 as a code owner January 28, 2025 04:01
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit b5ef8f2
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/679856842913fd00081fd35f
😎 Deploy Preview https://deploy-preview-1794--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant