Make MOPS tests tolerant of implementation options. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most MOPS sequences implement one of options "A" or "B", with slightly different flags in each case. Some `cpy` sequences also permit either forward or backward iteration, with different register results. This relies on a new overloaded form of `Equal64` that checks that a register matches any one of the listed reference values. In addition, renumber registers to avoid the use of `x16` in a couple of tests, because this is a MacroAssembler scratch register and could cause issues in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most MOPS sequences implement one of options "A" or "B", with slightly different flags in each case. Some
cpysequences also permit either forward or backward iteration, with different register results.This relies on a new overloaded form of
Equal64that checks that a register matches any one of the listed reference values.In addition, renumber registers to avoid the use of
x16in a couple of tests, because this is a MacroAssembler scratch register and could cause issues in the future.