Boottime mean counts #44
Conversation
|
@roxell Drafted out an idea for an initial way to display the number of entries included in the mean. Can you think of a good way to sanity check the outputs here? I think my code is correct, but wasn't 100% sure of the best way to check - I can probably work out how to create a small test case if that's the easiest way. Also think there are prettier ways to display the data but that can be investigated later :) |
katieworton
force-pushed
the
boottime-mean-counts
branch
2 times, most recently
from
afd50b4 to
bae5aba
Compare
|
Changed this so instead of creating a table, it adds the numbers to the legend. Also added patches to make the legend in alphabetical order & removed the creation of a DataFrame that was never used before being reassigned. |
squad-track-duration
Outdated
| markers=True, | ||
| labels={"build_name_device": "Build name - device"}, | ||
| labels={"build_name_device_count": "Build name - device (# boottimes)"}, |
There was a problem hiding this comment.
'Build name - device (mean over number of boots)'
squad-track-duration
Outdated
| .update_layout(xaxis_title="Version", yaxis_title="Boot time"), | ||
| f"Line graph, {args.build_name.split('-')[-1]}", | ||
| f"This line graph, is generated from \"{args.build_name.split('-')[-1]}\".", | ||
| f"This line graph, is generated from an average over {count_per_device2[col_name_boottime_count].sum()} boottimes for \"{args.build_name.split('-')[-1]}\".", |
There was a problem hiding this comment.
So the average isn't over this, different per device right.
Can we reformulate it to mach that?
Maybe something like this?
"This line graph, is generated form an average (or a mean) over number of boots, the number of boots is presented in the 'Build name - device (mean over number of boots)' in the line graph."
There was a problem hiding this comment.
Updated the text a bit (and for the other comment, too) - let me know what you think!
katieworton
force-pushed
the
boottime-mean-counts
branch
from
72a5c2c to
afab157
Compare
Add a table of information which displays how many boottimes were included in the mean boottime for each device. Signed-off-by: Katie Worton <[email protected]>
Remove code that creates a DataFrame then reassigns it before it is ever used. Signed-off-by: Katie Worton <[email protected]>
Update the sorting of the data so it is sorted by the legend lines then by created_at. This will ensure the data for each graph line is in the correct order while also putting the legend in alphabetical order. Signed-off-by: Katie Worton <[email protected]>
katieworton
force-pushed
the
boottime-mean-counts
branch
from
afab157 to
cfb98da
Compare
|
@katieworton amazing, thank you. |
Add a table of information which displays how many boottimes were included in the mean boottime for each device.