Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

GitHub flake8 updates #34

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

katieworton
Copy link
Member

  • Update the Github workflows file to check Python files that don't end in .py by adding "squad-*" to the checks
  • Update the outstanding Python file that doesn't end in .py to fit the convention of these files starting with "squad-"

Some of the scripts in the repo are Python files that flake8 should
check, but flake8 only checks .py files. Additionally, flake8 may crash
if given a non-Python file. Work around these issues by passing
"squad-*" to flake8, so it checks the Python scripts that begin with
"squad-" from this repo.

Fixes: c4f195c (".github: enable flake8 checks")
Signed-off-by: Katie Worton <[email protected]>
Rename read-skipfile-results to squad-read-skipfile-results to align
with naming conventions of other Python files in repo. This means that
it will be checked by the "squad-*" flake8 check.

Signed-off-by: Katie Worton <[email protected]>
Fix flake8 errors after adding the non-.py Python files to the flake8
checks.

Signed-off-by: Katie Worton <[email protected]>
@katieworton
Copy link
Member Author

Pushed an update that goes through and fixes the errors and warnings that were introduced by the extra files being checked.

Previous failures which were corrected can be seen here: https://github.com/Linaro/squad-client-utils/actions/runs/6970859748/job/18969663246

@roxell roxell merged commit 7036d3f into Linaro:master Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants