This repository was archived by the owner on Jul 30, 2024. It is now read-only.
GitHub flake8 updates #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the scripts in the repo are Python files that flake8 should check, but flake8 only checks .py files. Additionally, flake8 may crash if given a non-Python file. Work around these issues by passing "squad-*" to flake8, so it checks the Python scripts that begin with "squad-" from this repo. Fixes: c4f195c (".github: enable flake8 checks") Signed-off-by: Katie Worton <[email protected]>
Rename read-skipfile-results to squad-read-skipfile-results to align with naming conventions of other Python files in repo. This means that it will be checked by the "squad-*" flake8 check. Signed-off-by: Katie Worton <[email protected]>
Fix flake8 errors after adding the non-.py Python files to the flake8 checks. Signed-off-by: Katie Worton <[email protected]>
|
Pushed an update that goes through and fixes the errors and warnings that were introduced by the extra files being checked. Previous failures which were corrected can be seen here: https://github.com/Linaro/squad-client-utils/actions/runs/6970859748/job/18969663246 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.pyby adding "squad-*" to the checks.pyto fit the convention of these files starting with "squad-"